GNOME Bugzilla – Bug 336026
Make fallback shaper in modules work
Last modified: 2007-06-20 20:09:18 UTC
Currently the code in most modules contains a fallback (non-OpenType) shaper, but the conditional is written such that the fallback code is never used. This is because if the font is not OpenType, we simply create a dummy ruleset for it. This makes non-OpenType fonts like the TrueType Bitstream Vera series to be not kerned. In the future I like to have a more fine-grained switch to fallback. For example if the font doesn't have an mkmk table, do fallback mark stacking, if it doesn't have 'mark' table, do fallback mark positioning, etc...
*** Bug 336540 has been marked as a duplicate of this bug. ***
Created attachment 62453 [details] [review] calling pango_fc_font_kern_glyphs if applied_gpos is false TTF fonts like Bitstream Vera, Arial, etc. are kerned again with this patch. Is this useful?
Thanks a lot! Will commit and make releases soon.
Committed. I'm not sure if it interacts with RTL correctly, but we'll see :). 2006-03-31 Behdad Esfahbod <behdad@gnome.org> Part of Bug 336026 – Make fallback shaper in modules work Patch from Denis Jacquerye. * pango/pango-ot-buffer.c (pango_ot_buffer_output): Call pango_fc_font_kern_glyphs if GPOS not applied.
Hi, you had asked me whether the Microsoft Arial font is an OpenType font or oldschool TrueType? How would I tell the former from the latter? regards Hadmut
Hadmut, can you just test with Pango from CVS and see if the problem is fixed now?
Behdad, that's much better. :-) Tested with that given arial.ttf: - libpango1-ruby works - rsvg works - inkscape works - gimp works thanks and regards Hadmut
We also should use fallback if the font doesn't have any GSUB/GPOS tables, to avoid going through HarfBuzz unnecessarily.
Mostly obsolete these days. The direction we are taking is to always go through the OpenType buffer, and use canned tables for missing features, instead of using separate fallback routes.