After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 335812 - HIG: Vertical space between Search, All, Artists, Albums, Titles buttons and browser
HIG: Vertical space between Search, All, Artists, Albums, Titles buttons and ...
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: User Interface
HEAD
Other All
: Normal minor
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-03-24 09:53 UTC by Tamim
Modified: 2008-10-01 21:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Zoomed in on the buttons. Notice the buttons overlap the widget below. (21.44 KB, image/png)
2006-06-11 15:32 UTC, Amadeus 		  Details
Zoomed in on the scroller. Notice that there are an extra line from the buttons above the scroller (18.49 KB, image/png)
2006-06-11 15:33 UTC, Amadeus 		  Details
patch (603 bytes, patch)
2006-06-17 02:08 UTC, James "Doc" Livingston 		committed Details | Review
A screenshot with a 3 pixel patch applied. (3.01 KB, image/png)
2006-06-18 22:48 UTC, Amadeus 		  Details
Screenshot of 0.11.0 showing no issue (4.82 KB, image/png)
2007-06-18 08:01 UTC, Shilo 		  Details

Description Tamim 2006-03-24 09:53:16 UTC 
The amount of space between the search buttons and the browser pane looks odd. I
think it'll improve the look further if some vertical space is added. 

Other information:
Comment 1 Amadeus 2006-04-20 10:01:05 UTC 
I have filed a request for the search entry and buttons to become a toolbar in Bug Bug #339143 which I think would be a good solution for this.
Comment 2 James "Doc" Livingston 2006-06-07 14:15:27 UTC 
This has been fixed by the new "search bar" design with 0.9.4 onwards.
Comment 3 Amadeus 2006-06-11 15:30:46 UTC 
I think we are talking about different things?

The bug is still in the latest cvs. See attached screenshots.
Comment 4 Amadeus 2006-06-11 15:32:02 UTC 
Created attachment 67132 [details]
Zoomed in on the buttons. Notice the buttons overlap the widget below.
Comment 5 Amadeus 2006-06-11 15:33:13 UTC 
Created attachment 67133 [details]
Zoomed in on the scroller. Notice that there are an extra line from the buttons above the scroller
Comment 6 James "Doc" Livingston 2006-06-17 02:08:31 UTC 
Created attachment 67523 [details] [review]
patch

Sorry, I misunderstood when I was doing some triage.

This patch changes it so the "source header" (which is where the search bar is) has 3 pixels of padding around it. I'm not sure what amount is best to use, but this seems to stop the overlap for me.
Comment 7 Amadeus 2006-06-18 22:48:05 UTC 
Created attachment 67596 [details]
A screenshot with a 3 pixel patch applied.

The 3 pixel padding patch seams to fix the overlap bug, but the underline bug is still there. See this screenshot.
Comment 8 Shilo 2007-06-18 08:01:15 UTC 
Created attachment 90188 [details]
Screenshot of 0.11.0 showing no issue

I believe this bug is gone.  If I'm looking at what I'm supposed to be, this recent screenshot doesn't have the same issue.
Comment 9 Amadeus 2007-06-19 01:36:03 UTC 
I use the latest svn, and it is still there.

As you can see on your screenshot the distance on the bottom is very narrow, and choosing other themes, it gets worse.
Comment 10 William Jon McCann 2008-10-01 21:00:11 UTC 
I've committed the spacing fix.  Pretty sure the underline issue is due to a buggy theme.