GNOME Bugzilla – Bug 335367
if panel is on bottom, 'enter' does the wrong thing on results
Last modified: 2006-08-28 18:39:56 UTC
I just moved my deskbar to my bottom panel. Now, when I hit 'enter' after typing something, instead of launching what it should (the first item in the list) it appears to launch the *top* item in the list, i.e., the *last* item (since search order is reversed.) This is really really irritating, since it means I have to use my mouse, whereas previously I could just use the keyboard. :/
I can confirm this. When the launchbar is on a top panel, it works fine. It seems that launchbar rearranges the ordering of the plugins depending on whether you're on top or bottom. It puts the most relevant action closest to the search box (which is expected). However, when you hit enter, it always executes the action at the top of the list. When you have deskbar on the bottom panel, it should execute the action at the bottom of the list. I agree it's very frustrating.. especially when you're so excited about using one of the best new additions to gnome!
I've been looking through the source and can't find where this happens. My best hunch is in deskbar/ui/completion/DeskbarEntry.py somewhere around line #132 -- I could be wrong, though. I tried changing get_iter_first() to get_iter_last() to see if a mere hack would do it, but it didn't seem to change the behavior. Is anyone else willing to take a look at this?
Created attachment 62848 [details] [review] Select bottom hit for bottom panel applets Proposed patch attached. It is diffed against CVS head but I think it should apply against 2.14.0.1 too... Ben: The completion ui is deprecated, are you sure it is the one you are using? (The patch does not fix that ui - only the new ones (cuemiac and entriac)).
Thanks for the patch ! Applied on HEAD, waiting for backport
*** Bug 337013 has been marked as a duplicate of this bug. ***
Patch works for me! Thanks!