After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 335349 - bad GList use in eel-enumeration.c
bad GList use in eel-enumeration.c
Status: RESOLVED FIXED
Product: eel
Classification: Deprecated
Component: general
2.14.x
Other All
: High normal
: 2.14.x
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-03-21 12:36 UTC by Paolo Borelli
Modified: 2006-03-22 08:56 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

Attachments
patch (2.39 KB, patch)
2006-03-21 12:36 UTC, Paolo Borelli 		committed Details | Review

Description Paolo Borelli 2006-03-21 12:36:16 UTC 
The attached patch removes some silly O(N^2) uses of GList in eel-enumeration.c.

No idea if eel-enumeration is used with lists long enough to make a difference in real life, but still a good idea to fix it. I found it with a grep script.
Comment 1 Paolo Borelli 2006-03-21 12:36:47 UTC 
Created attachment 61684 [details] [review]
patch
Comment 2 Christian Neumair 2006-03-21 14:33:12 UTC 
Thanks for your bug report, good catch!

Maybe you could submit the patch to the nautilus mailing list [1]?

[1] http://mail.gnome.org/mailman/listinfo/nautilus-list
Comment 3 Paolo Borelli 2006-03-22 08:56:50 UTC 
Approved by Martin and committed.