GNOME Bugzilla – Bug 335241
[KB-Fixed] Send/Receive Messages window too big
Last modified: 2013-09-10 14:04:26 UTC
When having more than 12 email accounts, the send/receive messages window gets too big. On a 1024x768 gets out of screen. Maybe a lower font solve this ? Other information:
probably a duplicate.
Created attachment 67832 [details] [review] scroll box added to the send receive pop up
Fixed to head.
*** Bug 302917 has been marked as a duplicate of this bug. ***
reopening. this is definitely not the way to go, perhaps it works for you, but it does not work for me, see screenshot. :-)
Created attachment 68936 [details] screenshot. don't force me to scroll/resize when there is no need to. thanks. :-)
what do u think can be done in your opinion?
Scroll bar is the way to go. May be the max size could be little bigger. When my a/c name is little bigger I get the hscroll. and over 3 I get the vscroll.
err... well. it worked perfectly before, so it seems that before the patch was applied, this window was somehow able to find out which height and width length would be good to display everything properly. so please display the scroll bars only when they are actually needed - no idea if evolution itself can find this out, though. :-/ i at least vote for removing the horizontal scrolling and get back to a human width preset as it has been before - what is horizontal scrolling for? if i have 4000 mail accounts, i have to scroll vertically, but not horizontally! and if i really can get only three accounts displayed without resizing the window myself, i vote for reverting this patch entirely - to me, the harm seems to be bigger than the benefit. there are way more evolutionusers with <=10 accounts then >10 accounts. ;-)
I agree to removal of hscroll and setting the size approx to 5a/c may be 500px. So that even if some one uses 800x600, it wont go out of screen.
srinivasa: sounds reasonible. one could even make sure that the window is centered by fixing bug 325882, by the way. ;-)
what was the code before? how did evolution find out to get the just-fits-horizontal size? i'm against having a hardcoded width here, if there wasn't one before.
andre, prev no fixed size, it picks the max/add of sizes of all widgets. thatz y it grows. we need to fix to some size and say grow to scroll beyond this.
Srinivasa, my inicial post was because i have to monitor 12 email accounts, and on the 1024x768 laptop the window goes out of screen. Of course on the desktop pc, with 1600x1200 all goes ok. So, can the scroll appear if the window_height > screen_height - 50px ? I putted 50px as an example of a defined margin.
garr... this makes me sick. EVERYBODY has to scroll around currently, EVERYBODY. srini, can we please fix this? thanks.
*** Bug 349103 has been marked as a duplicate of this bug. ***
Created attachment 69957 [details] [review] Proposed patch
It will grow automatically till 750x340 by TAKE_NEEDED method, beyond which it starts showing scroll bar. Andre can you try this patch?
Created attachment 69958 [details] [review] Updated patch Missed one condition. sorry dudes.
aahh.... wonderful, perfect, adorable. everything fine now with this patch, no more useless scrolling. let's get this in.
Fixed to HEAD.
*** Bug 350266 has been marked as a duplicate of this bug. ***
*** Bug 354116 has been marked as a duplicate of this bug. ***
*** Bug 438639 has been marked as a duplicate of this bug. ***
Reopening, this is still a problem. See: http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240147
I think ellipsize would be a good deal but beyond a threshold.
If I may open up this discussion again, I see three problems with the way the dialog is currently being constructed. 1) The GtkLabel that shows the account name in bold followed by the URI is not being ellipsized. It should be in PANGO_ELLIPSIZE_END mode [*]. 2) All of the widgets are being attached to the GtkTable with horizontal resizing behavior of GTK_EXPAND | GTK_FILL. This is wrong. The only column that should be expanding and filling is the label column. 3) The policy of the GtkScrolledWindow should be to never, ever, EVER show a horizontal scrollbar. Ever. [*] By the way, what exactly is the difference between a GtkLabel in ellipsize mode and an EClippedLabel? Do we really still need this widget?
Created attachment 88235 [details] [review] Proposed patch This patch seems to work well for me. It reverts the dialog_map() function and implements my suggestions above. What do others think? As a sidenote, maybe we should write custom widget for displaying each account in this dialog. The logic in build_dialog() is just really messy and needs to be broken up better.
Created attachment 88238 [details] Screenshot Here's what this patch gives me when I add a bunch of accounts with ridiculously long names. If I stretch the dialog horizontally, only the labels expand.
(In reply to comment #9) > and if i really can get only three accounts displayed without resizing the > window myself, i vote for reverting this patch entirely - to me, the harm seems > to be bigger than the benefit. there are way more evolutionusers with <=10 > accounts then >10 accounts. ;-) One thing we could do to address the vertical scrollbar objection is store the dialog's GtkVBox dimensions in GConf. The current hard-coded dimensions (600x200) seem like a reasonable default, but it the user makes it the dialog bigger it should stay bigger.
wow, this looks great :) trying that tonight. (In reply to comment #30) I agree that if the user makes the windows bigger, evo should remember. What about the position though ?
> (In reply to comment #30) > I agree that if the user makes the windows bigger, evo should remember. What > about the position though ? I think the dialog should always appear centered over the main window (GTK_WIN_POS_CENTER_ON_PARENT), so I don't see a need to store the position.
Matthew you patch and the other suggestion looks fine. Please go-ahead :)
Committed the patch in comment #28 to trunk (revision 33576). I plan to do some follow-up work related to this. See my footnotes in comment #27 and comment #28 (and _maybe_ comment #32 if there's sufficient interest).
Bug #335241 (a dupe of this) was reopened due to an Ubuntu bug: Ubuntu https://bugs.launchpad.net/ubuntu/+source/evolution/+bug/120790 is similar and still happening using evolution 2.11.3, reopening The gist of the downstream bug is as follows: Suggestion: Please, 1. let Evolution remember the enlarged windows as a default setting and/or 2. let Evolution show more than 4 account settings at the pop up window as a default ( like Feisty) Part 1 is consistent with comment #30. Part 2 is unnecessary, in my opinion. Srini, what do you think?
I voted for the first one. If you do the first one, the second can be achieved. If the user resizes to a bigger size, he can see all. Lets not do the second part. I will go with you Matthew.
Bumping version to a stable release.
I think this is more or less fixed in the kill-bonobo branch. EClippedLabel is long dead, the window already remembers its size, and with Bonobo out of the way we can finally center the thing properly over the main window.
The "kill-bonobo" branch has been merged into "master" and will debut as Evolution 2.29.1. We believe the branch has addressed the reported issue. If you find the issue still exists in version 2.29 or later please feel free to re-open this bug. Closing as FIXED.
*** Bug 267386 has been marked as a duplicate of this bug. ***