After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 334892 - Orca speaks "No focus" too often
Orca speaks "No focus" too often
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
unspecified
Other All
: Normal enhancement
: ---
Assigned To: Rich Burridge
Orca Maintainers
: 342142 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-03-17 15:09 UTC by Willie Walker
Modified: 2006-07-12 17:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix for the problem (I hope). (5.12 KB, patch)
2006-07-12 16:08 UTC, Rich Burridge 		none Details | Review

Description Willie Walker 2006-03-17 15:09:45 UTC 
Orca sometimes speaks "No focus" too often.  This can occur if there is a delay between something losing 
focus and something gaining focus.  Perhaps Orca should consider using a timer before speaking "No 
focus."
Comment 1 Willie Walker 2006-05-19 13:09:25 UTC 
*** Bug 342142 has been marked as a duplicate of this bug. ***
Comment 2 Rich Burridge 2006-07-11 21:30:10 UTC 
We discussed this a bit today. Adding comments here so
I don't forget them.

Currently "No focus" is spoken or brailled in four places
in default.py:

  - whereAmI
  - locusOfFocusChanged
  - visualAppearanceChanged
  - updateBraille

The plan is to move this logic into the _dequeueEvent GTK
idle thread handler. This would be just before:

  event = self._eventQueue.get()

We would check to see if the event queue was empty and if so,
we'd test if orca.locusOfFocus was None. If it was, and if a
certain period of time had passed since the last utterance
(time period determined by a new variable in settings.py) and
if the last utterance wasn't "No focus", then we'd speak
"No focus". This will involve saving away a little more state:

  - the last utterance
  - the time of the last utterance.
Comment 3 Rich Burridge 2006-07-12 16:08:18 UTC 
Created attachment 68824 [details] [review]
Fix for the problem (I hope).

Attaching a fix that I believe solves this. I tried starting up
Evolution. As the main Evolution window comes up there were three
occurances of "No Focus" in a row before this change. Not there is
only one.

Will/Mike, could you review (and possibly try) these changes before I
check them in?

Thanks.
Comment 4 Rich Burridge 2006-07-12 17:03:47 UTC 
After feedback from Will and Mike, it looks like this fix is okay.
I've checked it into CVS HEAD and closed the bug as FIXED. Thanks.