GNOME Bugzilla – Bug 334584
Import cancel or copy uncheck should clean up directories.
Last modified: 2006-03-15 18:49:36 UTC
Please describe the problem: When you import from file in f-spot unchecking the "Copy files to Photos folder" check box or Cancelling the import currently deletes any copied files but leaves behind any directories created as part of the import process. It would be nice if f-spot cleaned these up after itself too. Steps to reproduce: 1. Remove your ~/Photos directory if it exists. 2. Import some photos (preferably covering a reasonable date range). 3. Either: uncheck the "Copy files to Photos folder" and finish importing OR: cancel the import. 4. Check your ~/Photos directory and see that all the directories created as part of the import are still there. Actual results: The directories are left orphaned. Expected results: f-spot deletes any directories it created that are no longer needed. Does this happen every time? Yes Other information:
Created attachment 61251 [details] [review] patch to fix this bug This patch cleans up any newly created directories after a cancel or uncheck of the copy check box. It makes sure that the directory is empty (of both files and other directories) before deleting it. It also removes the unecessary call to Finish () from Cancel ().
committed to CVS, thanks for the patch!