Created attachment 61208 [details]
photo with dodgy metadata

This photo should cause the exception to be thrown.

This seems to work for me with cvs, is it still giving you problems?

Yep. I am using the latest CVS an when trying to import a file with this EXIF info I get the following on the console.

item ImportCommand+SourceItem
Scanning /home/james/temp/broken
loading exif data
Error importing /home/james/temp/broken/00017.jpg
System.ArgumentNullException: Argument cannot be null.
Parameter name: src
in <0x00000> <unknown method>
in (wrapper managed-to-native) System.Runtime.InteropServices.Marshal:copy_from_unmanaged (intptr,int,System.Array,int)
in <0x0002e> System.Runtime.InteropServices.Marshal:Copy (IntPtr source, System.Byte[] destination, Int32 startIndex, Int32 length)
in <0x00069> Exif.ExifEntry:get_Data ()
in <0x00079> FSpot.JpegFile:get_Description ()
in <0x0008a> PhotoStore:Create (System.String newPath, System.String origPath, Gdk.Pixbuf thumbnail)
in <0x0012e> FileImportBackend:Step (.Photo photo, Gdk.Pixbuf thumbnail, System.Int32 count)
Could not import file
Stopping

I guess it might possibly be a problem in libexif. I am running 0.6.12-2 (ubuntu breezy). Let me know if I can supply any other info that might be useful.

Hi everyone,

I've the same problem. I'm running f-spot 0.1.11 and libexif 0.6.12-2 on Ubuntu Dapper.

All picture in 1200x1600 (so vertical) (see <a href="http://bugzilla.gnome.org/attachment.cgi?id=61208 ">James attachement</a>) aren't impoted. The 1600x1200 (horizontal) are in the catalog.

Bye

Time to move away from libexif?

See on ubuntu bugzilla : https://launchpad.net/distros/ubuntu/+source/f-spot/+bug/37972

1. - Import some pictures from your camera with gnome-volume-manager-gthumb to any folder. If your camera has that feature, pictures shot in vertical possition will be automatically properly rotated.

2.- Import that folder with f-spot. Pictures which had been rotated just will not show up.

% file *
img_0481.jpg: JPEG image data, EXIF standard 2.2
img_0482.jpg: JPEG image data, EXIF standard 2.2
img_0483.jpg: JPEG image data, JFIF standard 1.01

The two first are well imported, the third not.

FWIW, I also have this problem with F-spot 0.1.11 and up to date Ubuntu Dapper.

Brice, regarding comment #7, perhaps you can raise a new bug with the JFIF problem.
Also do attach a photo with JFIF standard 1.01 to this bug.

Lets keep it to one problem per bug.

Bug #339213 seems to be a duplicate of this one. These two should probably be merged.

Larry wanted the following information in bug #339213
---
What version of libexif do you have installed?  
What is the full name of the shared library it provides.
What are the contents of the /usr/lib/f-spot/f-spot.exe.config file?
---

Version of libexif is 0.6.12-2 (ubuntu breezy)

It provides the folloing files to /usr/lib:
/usr/lib/libexif.so.12.0.0
/usr/lib/libexif.so.12

The contents of /usr/lib/f-spot/f-spot.exe.config
<configuration>
  <dllmap dll="libglib-2.0-0.dll" target="libglib-2.0.so.0"/>
  <dllmap dll="libgobject-2.0-0.dll" target="libgobject-2.0.so.0"/>
  <dllmap dll="libgtk-win32-2.0-0.dll" target="libgtk-x11-2.0.so.0"/>
  <dllmap dll="libgdk-2.0-0.dll" target="libgdk-x11-2.0.so.0"/>
  <dllmap dll="libgdk_pixbuf-2.0-0.dll" target="libgdk_pixbuf-2.0.so.0"/>
  <dllmap dll="libgnomevfs-2-0.dll" target="libgnomevfs-2.so.0"/>
  <dllmap dll="libgnomeui-2-0.dll" target="libgnomeui-2.so.0"/>
  <dllmap dll="libfspot" target="/usr/lib/f-spot/libfspot.so.0"/>
  <dllmap dll="libfspoteog" target="/usr/lib/f-spot/libfspoteog.so.0"/>
  <dllmap dll="libfspotjpeg" target="/usr/lib/f-spot/libfspotjpg.so.0"/>
  <dllmap dll="liblcms-1.0.0.dll" target="liblcms.so.1"/>
  <dllmap dll="libexif.dll" target="libexif.so.12"/>
</configuration>

Hi, 

Could import this picture with Dapper and latest CVS with no problems.
libexif 0.6.12-2

When I select the photo the following exception appeared on the console though.
System.Exception: Invalid UserComment value, no charset found
in <0x001f6> FSpot.Tiff.UserComment:.ctor (System.Byte[] raw_data, Boolean little)
in <0x0003f> FSpot.Tiff.DirectoryEntry:get_UserCommentValue ()
in <0x00107> FSpot.Tiff.DirectoryEntry:get_ValueAsString ()
in <0x005a3> FSpot.Tiff.Header:SelectDirectory (FSpot.Tiff.ImageDirectory dir, StatementSink sink)
in <0x00716> FSpot.Tiff.Header:SelectDirectory (FSpot.Tiff.ImageDirectory dir, StatementSink sink)
open uri = file:///home/bengt/Photos/2006/3/4/00017small.jpg

*** Bug 341948 has been marked as a duplicate of this bug. ***

*** Bug 339213 has been marked as a duplicate of this bug. ***

*** Bug 339247 has been marked as a duplicate of this bug. ***

should be fixed and work just fine in cvs now.  There is also a patch for f-spot-0-1-branch that dapper can pick up.

stable and head have fixes committed for this

Nice work. Thank you! ;-D

Just managed to test this myself. As you say Larry - all seems to be fixed now. Thanks very much and sorry I've taken so long to get back to this bug!

Is it possible for someone to build an unofficial package that can be installed on a dapper box?