After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 334123 - [taglibmux] fixes for TPOS and TCOP
[taglibmux] fixes for TPOS and TCOP
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-03-10 12:02 UTC by Alex Lancaster
Modified: 2006-05-03 21:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fixes TPOS, adds TCOP (1.38 KB, patch)
2006-03-10 12:02 UTC, Alex Lancaster
committed Details | Review

Description Alex Lancaster 2006-03-10 12:02:07 UTC
Disc number is broken, it should use TPOS, not TRCK.  This patch also adds support for GST_TAG_COPYRIGHT, maps to "TCOP".
Comment 1 Alex Lancaster 2006-03-10 12:02:57 UTC
Created attachment 61028 [details] [review]
Fixes TPOS, adds TCOP
Comment 2 Christophe Fergeau 2006-03-10 12:57:27 UTC
I should be more careful when copying and pasting code... You forgot to g_free (copyright). Maybe "Setting album number to XXX" would be more readable than "Setting position in set to XXX"?
Comment 3 Alex Lancaster 2006-03-10 13:07:13 UTC
Sounds good.
Comment 4 Alex Lancaster 2006-03-11 09:41:43 UTC
Do you want me to update the patches before committing?   Feel free to modify before you check them in.