After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 333944 - mem leak in ev-window-title
mem leak in ev-window-title
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-03-08 20:53 UTC by Christian Persch
Modified: 2006-04-24 13:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Trivial patch (983 bytes, patch)
2006-03-09 16:58 UTC, Carlos Garcia Campos
committed Details | Review

Description Christian Persch 2006-03-08 20:53:44 UTC
==16259== 297 (268 direct, 29 indirect) bytes in 16 blocks are definitely lost in loss record 171 of 305
==16259==    at 0x401B422: malloc (vg_replace_malloc.c:149)
==16259==    by 0x4CA2F36: g_malloc (gmem.c:131)
==16259==    by 0x4CB2C65: g_strdup (gstrfuncs.c:91)
==16259==    by 0x8078CD1: ev_window_title_update (ev-window-title.c:115)

in ev_window_title_update, |title| is set from g_strdup but never freed.
Comment 1 Carlos Garcia Campos 2006-03-09 16:58:57 UTC
Created attachment 60988 [details] [review]
Trivial patch

Trivial patch that fixes the memleak
Comment 2 Nickolay V. Shmyrev 2006-03-09 22:55:26 UTC
Thanks for the patch, Carlos. After some time I think the bug is so important we should fix it in this release. Although I don't know
Comment 3 Carlos Garcia Campos 2006-03-14 18:40:49 UTC
2006-03-14  Carlos Garcia Campos  <carlosgc@gnome.org>

        * shell/ev-window-title (ev_window_title_update):

        Fix memory leak in window title. Fixes bug #333944
Comment 4 Nickolay V. Shmyrev 2006-04-24 13:35:23 UTC
*** Bug 339497 has been marked as a duplicate of this bug. ***