After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 333922 - inner-border properties for GtkEntry
inner-border properties for GtkEntry
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other All
: Normal enhancement
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2006-03-08 16:27 UTC by Michael Natterer
Modified: 2006-03-10 10:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch implementing the above (15.65 KB, patch)
2006-03-08 16:31 UTC, Michael Natterer 		committed Details | Review

Description Michael Natterer 2006-03-08 16:27:10 UTC 
maemo-gtk has a patch that turns the INNER_BORDER #define in
GtkEntry into horizontal-border and vertical-border style properties.

I refactored that to be one style property of type GtkBorder *plus*
an ordinary property (plus API) of the same name that overrides
the style property if set. The rationale for having both style
and object property is in the newly added API's inline docs.

Patch follows.
Comment 1 Michael Natterer 2006-03-08 16:31:23 UTC 
Created attachment 60925 [details] [review]
Patch implementing the above
Comment 2 Tim Janik 2006-03-09 16:23:19 UTC 
ok, the patch looks good to me and i think it should go in without modifications.
Comment 3 Matthias Clasen 2006-03-09 18:36:13 UTC 
Looks ok to me too, even though we haven't done this kind of style property + regular property thing before.
Comment 4 Michael Natterer 2006-03-10 10:31:11 UTC 
Fixed in CVS:

2006-03-10  Michael Natterer  <mitch@gimp.org>

	* gtk/gtkentry.[ch]: applied refactored patch from maemo-gtk that
	replaces the INNER_BORDER define by an "inner-border" style
	property of type GtkBorder. Additionally, add an "inner-border"
	object property plus API which allows to override any theme
	border, to allow pixel-perfect positioning of entries for inline
	editing. Fixes bug #333922.

	* gtk/gtk.symbols: add the new public functions.