After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 333857 - If no edits are available, combobox should be insensitive
If no edits are available, combobox should be insensitive
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: General
GIT
Other Linux
: Normal enhancement
: 0.7.0
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2006-03-08 06:50 UTC by Christopher Aillon
Modified: 2009-08-10 12:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Online patch (635 bytes, patch)
2006-06-01 03:25 UTC, Bengt Thuree 		needs-work Details | Review

Description Christopher Aillon 2006-03-08 06:50:46 UTC 
Clicking on the version combobox yields the already selected "Original" and an insensitive "(No edits)".

The combobox should just be insensitive itself so users know there aren't any other possible selections.
Comment 1 Bengt Thuree 2006-06-01 03:25:25 UTC 
Created attachment 66570 [details] [review]
Online patch

A one liner patch that disabled the Version drop down menu if there is no modifed versions.

--- ../../f-spot/src/InfoBox.cs 2006-03-23 00:57:27.000000000 +0800
+++ src/InfoBox.cs      2006-06-01 11:22:46.000000000 +0800
@@ -272,7 +272,7 @@ public class InfoBox : VBox {
    photo.Time.ToShortDateString (),
    photo.Time.ToShortTimeString ());
 #endif
-   version_option_menu.Sensitive = true;
+   version_option_menu.Sensitive = (photo.VersionIds.Length > 1);  // Enable only if there are modified versions.
    PhotoVersionMenu menu = new PhotoVersionMenu (photo);
    menu.VersionIdChanged += new PhotoVersionMenu.VersionIdChangedHandler (HandleVersionIdChanged);
    menu.WidthRequest = version_option_menu.Allocation.Width;
Comment 2 Larry Ewing 2006-06-06 14:48:31 UTC 
I'd think I'd prefer to add a "Create new Version" item to the menu rather than just desensitizing it.
Comment 3 Stephane Delcroix 2006-06-13 12:25:18 UTC 
There are already a lot of ways to 'Create a new version'. Think about the 'Edit View', the 'Open With' popup, the 'Create new version' in the File menu...

I don't think the user will need one more 'Create new Version' in the InfoBox. Plus, creating a new version without doing any edit on it is -almost- useless.

My €.02, fot what it worth...
Comment 4 Christopher Aillon 2006-06-13 16:06:39 UTC 
Maybe the other places are the wrong places, then.  Don't discount UI ideas simply because there are other ways to get at them.  Choose the best one and go with that.  Note that I'm neither arguing for or against comment 2, simply trying to make sure this gets properly thought out.
Comment 5 antistress 2008-06-23 22:57:47 UTC 
i also think that combobox should be insensitive in that case : seems more intuitive to me (i was about to fill a similar bug report)
Comment 6 antistress 2008-06-23 23:03:42 UTC 
also think that it would allow to quickly know what picture has several versions (by selecting pictures one by one while you check the combobox). At present time, you can't.
Comment 7 Ruben Vermeersch 2009-08-04 11:34:40 UTC 
Merge request for this here:
http://gitorious.org/f-spot/mainline/merge_requests/1036
Comment 8 Stephane Delcroix 2009-08-10 10:50:34 UTC 
Even if I think Lary is right in comment #2, I pushed that patch for now.