After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 333743 - Gtk HEAD (2.10) GtkNotebook tab dragging crashes any application that had tab dragging previously
Gtk HEAD (2.10) GtkNotebook tab dragging crashes any application that had tab...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkNotebook
unspecified
Other All
: Normal critical
: ---
Assigned To: gtk-bugs
gtk-bugs
: 333888 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-03-07 14:31 UTC by Iain
Modified: 2006-03-09 00:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (5.51 KB, patch)
2006-03-08 16:16 UTC, Carlos Garnacho 		none Details | Review

Description Iain 2006-03-07 14:31:41 UTC 
Steps to reproduce:
Upgrade to GTK+ HEAD with GtkNotebook tab dragging.
Start any application which had tab dnd (gedit, gnome-terminal, epiphany are the
ones I found)
Observe crash.

Stack trace:


Other information:
Problem is that some applications had previously added signals such as
"tab-added" "tab-removed" etc to the GtkNotebook class. As GTK+ now has those
signals but with different callback signatures from the custom signals, the
applications now crash.
Comment 1 Matthias Clasen 2006-03-07 16:38:02 UTC 
After talking to rambokid, we need to find names for the new signals which 
are not used by derived classes yet. 

Adding new signals is a lot more delicate than adding new vfuncs...
Comment 2 Matthias Clasen 2006-03-07 17:24:57 UTC 
Also rambokid pointed out that these should not be action signals, and use proper
types for their arguments instead of gpointer
Comment 3 Carlos Garnacho 2006-03-07 18:04:09 UTC 
My suggestion is would be to rename them to "page-added" and "page-removed", it makes sense after all, as the most important thing here is the child widget (page), not the tab widget

I can make a patch (fixing rambokid issues too) if you like
Comment 4 Matthias Clasen 2006-03-07 18:05:59 UTC 
that would be great
Comment 5 Carlos Garnacho 2006-03-08 16:16:39 UTC 
Created attachment 60923 [details] [review]
patch

for adding some more consistence, I've also renamed ::tab-reordered to ::page-reordered, and made gtk_notebook_reorder_child() to emit this signal
Comment 6 Carlos Garnacho 2006-03-08 16:18:26 UTC 
Oh, btw, I've tested it with gedit, gnome-terminal and ephy, they work just like they should :)
Comment 7 Matthias Clasen 2006-03-08 16:42:30 UTC 
Looks great. Feel free to commmit, otherwis I'll get around to it sometime...
Comment 8 Carlos Garnacho 2006-03-08 17:23:33 UTC 
I've just committed the patch to HEAD, thanks :)
Comment 9 Matthias Clasen 2006-03-09 00:29:15 UTC 
*** Bug 333888 has been marked as a duplicate of this bug. ***