GNOME Bugzilla – Bug 333340
Hitting enter before the lock dialog comes up causes it to try logging in with an empty password
Last modified: 2006-03-06 19:53:25 UTC
Upstreaming from: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177598 Description of problem: Hitting enter before the dialog pops up sends the event anyway and the dialog sits for a few seconds before it allows you to enter a new password How reproducible: Always Steps to Reproduce: 1. Lock the screen 2. hit enter Actual results: Dialog blocks for a few seconds before you can enter another password Expected results: Key events should work the same as in Xscreensaver. The first enter is ignored and just brings up the dialog if it is not showing. All other keystrokes are valid even if the dialog is hidden. An enter after any other keystroke should also be valid. Additional Info: The first space is also invalid. I still have Xscreensaver on my desktop if you want to take a look.
Created attachment 60780 [details] [review] patch Unfortunately, we just hit hard code freeze today. So, I guess this will have to wait.
Hey Vincent, can I get approval to commit this one liner?
You don't need approval yet: the freeze starts at midnight UTC. Still 4 hours left ;-)
Cool - off by one I guess. Committed. 2006-03-06 William Jon McCann <mccann@jhu.edu> * src/gs-window-x11.c (queue_key_event): Don't queue keypad enter presses. Fixes #333340