After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 332894 - 48x48 icons scaled down to 16x16
48x48 icons scaled down to 16x16
Status: RESOLVED FIXED
Product: adwaita-icon-theme
Classification: Core
Component: general
2.14.x
Other All
: Normal major
: ---
Assigned To: Jakub Steiner
Jakub Steiner
Depends on:
Blocks:
 
 
Reported: 2006-02-28 21:13 UTC by Luca Ferretti
Modified: 2006-03-14 20:21 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
Use Type=Treshold for raster icons in index.theme (6.94 KB, patch)
2006-03-02 10:53 UTC, Luca Ferretti
none Details | Review
s/Treshold/Threshold (7.03 KB, patch)
2006-03-02 13:43 UTC, Luca Ferretti
rejected Details | Review

Description Luca Ferretti 2006-02-28 21:13:47 UTC
Please describe the problem:
Due to those entries in index.theme

[48x48/filesystems]
Size=48
Context=FileSystems
Type=Scalable
MinSize=16
MaxSize=48

[48x48/mimetypes]
Size=48
Context=MimeTypes
Type=Scalable
MinSize=16
MaxSize=48

On my system file chooser shows 48x48 icons scaled to 16. Same for Place menu on
desktop.

I changed to Type=Fixed and remove *Size keys and now it seems to work fine...

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Luca Ferretti 2006-03-02 10:48:24 UTC
Changing those values as suggested don't really fix this issue or, better, it creates another one: icons in Places -> Recent Documents menu are 48x48 when smaller sized are not available.

The only way to really solve all huge icons bugs seems to use "Type=Treshold". I'm using it on my system and the following issues pointed here on bugzilla seems ok:
 * FUSA big icon is scaled down to menu icon size
 * icons in file selector are scaled down too (sockets icon)
 * MIME icons are scaled down in Recent Documents menu icons

I don't know if this just an hack and there is a bug in GTK+ code or panel code or elsewhere, but by now (1 week to 2.14) it works. For me, of course :-)

Moreover please note that Treshold is default/fallback value for Type key in Icon Theme Standard. What's the reason to use Fixed?
Comment 2 Luca Ferretti 2006-03-02 10:52:01 UTC
(In reply to comment #0)
> 
> On my system file chooser shows 48x48 icons scaled to 16. Same for Place menu
> on desktop.

I mean: alway, even if 16 or 24 version is available.
Comment 3 Luca Ferretti 2006-03-02 10:53:08 UTC
Created attachment 60476 [details] [review]
Use Type=Treshold for raster icons in index.theme
Comment 4 Ross Burton 2006-03-02 13:23:40 UTC
Shouldn't that be "threshold"?
Comment 5 Luca Ferretti 2006-03-02 13:43:18 UTC
Created attachment 60490 [details] [review]
s/Treshold/Threshold

Do'h! True, but "If not specified, the default is Threshold."
Comment 6 Marinus Schraal 2006-03-14 12:19:57 UTC
It seems to me this is a pretty important issue to get fixed before final 2.14 release. Could someone have another look at it ? It seems without this patch all icons in eg. nautilus places menu are scaled versions instead of pixmaps.
Comment 7 Rodney Dawes 2006-03-14 15:58:55 UTC
GTK+ should be preferring native size icons, when available. If it isn't, I presume to say that this is a GTK+ bug. Didn't this work in 2.12? It seems to work appropriately for me. Does just removing the MinSize help?
Comment 8 Marinus Schraal 2006-03-14 18:11:25 UTC
removing MinSize fixes the problems with the nautilus icons, but it doesn't fix a probably related problem. Gossip account icons are unusally big. It's not just me seeing this, there was this thread on the gossip ML :http://lists.imendio.com/pipermail/gossip-dev/2006-February/008549.html .

The patch in comment #5 seems to fix both issues.

I'm using gtk+-2.8.13 atm, I'll test with .15 , but the changelogs indicate nothing icon related has changed between those releases. This is with mainly a recent 2.14 rc release, in 2.12 I had no such problems.
Comment 9 Rodney Dawes 2006-03-14 20:21:22 UTC
OK. I've removed the MinSize in CVS to workaround the GTK+ bug. I don't want to make everything Threshold. It seems like the wrong solution to me, so I'm marking that patch as rejected. A 2.14.2 release will be up shortly.