After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 332659 - [patch] sylpheed support / fix a typo in gnome-default-applications.xml.in
[patch] sylpheed support / fix a typo in gnome-default-applications.xml.in
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] Preferred applications
2.13.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-02-26 18:59 UTC by Fryderyk Dziarmagowski
Modified: 2006-04-13 21:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix a typo / add Sylpheed support (1.06 KB, patch)
2006-02-26 19:00 UTC, Fryderyk Dziarmagowski 		none Details | Review
fixes a typo (779 bytes, patch)
2006-02-26 22:39 UTC, Fryderyk Dziarmagowski 		committed Details | Review
/home/luca/cvs/default-applications-sylpheed.patch (1.73 KB, patch)
2006-03-06 22:28 UTC, Luca Cavalli 		committed Details | Review

Description Fryderyk Dziarmagowski 2006-02-26 18:59:45 UTC 
Fixes a typo in gnome-default-applications.xml.in and adds Sylpheed support
Comment 1 Fryderyk Dziarmagowski 2006-02-26 19:00:44 UTC 
Created attachment 60168 [details] [review]
fix a typo / add Sylpheed support
Comment 2 Luca Cavalli 2006-02-26 20:52:13 UTC 
Since we are in string freeze, may you provide two separate patches, one to fix Sylpheed Claws executable typo and one to add Sylpheed? Doing this way the typo patch shall be applied without l10n approval. Thanks Fryderyk.
Comment 3 Fryderyk Dziarmagowski 2006-02-26 22:39:34 UTC 
Created attachment 60179 [details] [review]
fixes a typo
Comment 4 Fryderyk Dziarmagowski 2006-02-26 22:40:43 UTC 
Uploaded updated patch. Should I open a new bug for Sylpheed support?
Comment 5 Luca Cavalli 2006-02-26 23:33:04 UTC 
Thanks for the patch. Since I couldn't find Sebastien or Rodrigo for a quick approval, since GNOME 2.14.0 RC tarballs are due today and since the patch doesn't touch a single line of code, I committed it (fixing a typo in the patch too :) the executable is sylpheed-claws, not Sylpheed-claws).
I'm keeping the bug opend, so no need to open a new one for Sylpheed support.
Comment 6 Luca Cavalli 2006-03-06 22:28:27 UTC 
Created attachment 60807 [details] [review]
/home/luca/cvs/default-applications-sylpheed.patch

Splitted patch to add Sylpheed support.
Comment 7 Rodrigo Moya 2006-03-07 11:02:18 UTC 
The patch only adds the executable name (Sylpheed) for translation, and that does not need translation at all, right?
Comment 8 Luca Cavalli 2006-03-07 11:31:23 UTC 
It shouldn't need transtation (at least Sylpheed-Claws is never translated and the name is very similar) but I'm not an i18n expert. Nonetheless it is marked for translation like all other <_name> in XML (some of them need translation).
Comment 9 Luca Cavalli 2006-04-13 21:37:45 UTC 
Patch committed to HEAD.