After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 332639 - Fix memory leaks in draw_flat_box and gtk_treeview_get_header_index
Fix memory leaks in draw_flat_box and gtk_treeview_get_header_index
Status: RESOLVED FIXED
Product: gtk-engines
Classification: Deprecated
Component: clearlooks
2.7.x
Other All
: Normal critical
: ---
Assigned To: Richard Stellingwerff
gtk-engines maintainers
Depends on:
Blocks:
 
 
Reported: 2006-02-26 16:29 UTC by Mart Raudsepp
Modified: 2006-08-25 20:17 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

Attachments
Fix for both of the aforementioned leaks (2.90 KB, patch)
2006-02-26 16:31 UTC, Mart Raudsepp 		none Details | Review
Proposed backport of the fix for 2.6.10 (1.59 KB, patch)
2006-08-19 19:10 UTC, Loïc Minier 		none Details | Review

Description Mart Raudsepp 2006-02-26 16:29:21 UTC 
Please describe the problem:
Current CVS of the gtk-engines clearlooks engine leaks a cairo_t every flat_box
draw that isn't for a treeview selection, and a GList every GtkTreeView header
button draw.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Mart Raudsepp 2006-02-26 16:31:14 UTC 
Created attachment 60162 [details] [review]
Fix for both of the aforementioned leaks

Fixes the two memleaks and also makes the detail string check use known string length in the strncmp comparison as to not waste time on a strlen().
Comment 2 Matthias Clasen 2006-02-27 02:54:59 UTC 
Fun, combo_box_get_seperator_pos () also leaks the children lists
Comment 3 Richard Stellingwerff 2006-02-27 18:07:41 UTC 
2006-02-27  Richard A. Stellingwerff  <remenic@gmail.com>

    * engines/clearlooks/src/clearlooks_style.c: (draw_flat_box):
    * engines/clearlooks/src/support.c:
    (gtk_treeview_get_header_index):

    Applied patch from #332639. Fixes memory leaks.
Comment 4 Benoît Dejean 2006-08-19 15:00:19 UTC 
Would you please backport this fix ton 2.6 ?
Comment 5 Loïc Minier 2006-08-19 19:10:22 UTC 
Created attachment 71208 [details] [review]
Proposed backport of the fix for 2.6.10
Comment 6 Benjamin Berg 2006-08-25 20:17:45 UTC 
I commited the fix to the 2-6 branch.