After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 331526 - 3GP type detection is too simple
3GP type detection is too simple
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.10.3
Other All
: Normal normal
: 0.10.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-02-17 10:37 UTC by Tommi Myöhänen
Modified: 2006-02-22 10:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch that improves 3GP typefind (2.94 KB, patch)
2006-02-17 10:38 UTC, Tommi Myöhänen 		none Details | Review

Description Tommi Myöhänen 2006-02-17 10:37:34 UTC 
Please describe the problem:
Type detection fails with some 3gp clips and reports the mimetype to be "video/
quicktime" instead. For some 3GP clips typefind works as follows:

$ gst-typefind test.3gp
test.3gp - application/x-3gp
$ gst-typefind test.3gp
test.3gp - video/quicktime
$ gst-typefind test.3gp
test.3gp - application/x-3gp

So, it cannot decide what format the file actually is.

I will attach a patch that improves 3GP type detection.



Steps to reproduce:



Actual results:



Expected results:



Does this happen every time?



Other information:
Comment 1 Tommi Myöhänen 2006-02-17 10:38:27 UTC 
Created attachment 59566 [details] [review]
Patch that improves 3GP typefind
Comment 2 Jan Schmidt 2006-02-17 11:39:09 UTC 
Looks fine to me. Tommi, perhaps you should arrange CVS commit access to just commit this sort of thing directly?
Comment 3 Edward Hervey 2006-02-22 10:38:12 UTC 
commited, thanks again. You still might want to look into getting a cvs commit access. More information here : http://freedesktop.org/wiki/AccountRequests

2006-02-22  Tommi My�h�nen  <ext-tommi do myohanen at nokia dot com>
  	 
  	         Reviewed by : Edward Hervey  <edward@fluendo.com>
  	 
  	         * gst/typefind/gsttypefindfunctions.c: (q3gp_type_find),
  	         (qt_type_find):
  	         Better 3gp typefinding.