After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 331145 - another speed up patch
another speed up patch
Status: RESOLVED FIXED
Product: gnome-screensaver
Classification: Deprecated
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-screensaver maintainers
gnome-screensaver maintainers
Depends on:
Blocks:
 
 
Reported: 2006-02-14 15:38 UTC by Ray Strode [halfline]
Modified: 2006-07-31 18:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
make default size of images smaller and other speed ups (1.72 KB, patch)
2006-02-14 15:40 UTC, Ray Strode [halfline] 		needs-work Details | Review
cull patch (1.12 KB, patch)
2006-07-11 14:13 UTC, Matthias Clasen 		committed Details | Review

Description Ray Strode [halfline] 2006-02-14 15:38:45 UTC 
Hi,

So Fedora is still getting complaints about battery and cpu usage from the floaters screensaver.  I'm going to attach a patch we're using for test3 to try to help the situation.

It tweaks some of the numbers so the images are smaller most of the time, and it also turns on the culling logic that never quite worked before (but might work now with the change i made).

I don't know how much of this you want to go into the upstream release, but I'll attach the patch here in case you find it useful.
Comment 1 Ray Strode [halfline] 2006-02-14 15:40:09 UTC 
Created attachment 59350 [details] [review]
make default size of images smaller and other speed ups
Comment 2 William Jon McCann 2006-02-14 16:33:19 UTC 
Comment on attachment 59350 [details] [review]
make default size of images smaller and other speed ups

I committed some of this.   But bumped up the default count to 9 from 5.

#ifdef CULL_FLOATERS || 1
gives a compiler warning.  Might be better to just define CULL_FLOATERS

However, in that case the size and and floater variables will be used uninitialized.
Comment 3 William Jon McCann 2006-05-02 18:40:16 UTC 
I'll consider this fixed since it mostly is.
Comment 4 Matthias Clasen 2006-07-11 14:13:12 UTC 
Created attachment 68774 [details] [review]
cull patch

Here is a patch to fix the CULL_FLOATER optimization and turn it on unconditionally.
Comment 5 William Jon McCann 2006-07-31 18:31:10 UTC 
Strange.  I missed the bugmail from this for some reason.  Anyway, committed to HEAD.  Thanks.