GNOME Bugzilla – Bug 331117
UPS icons do not match theme
Last modified: 2006-02-25 22:28:38 UTC
UPS icons do not match the other icons. We need a decent set of icons *with* charging and discharging states.
Richard, Shouldn't we just asked the gnome-icon-theme and tango icon people (jimmac and co.) to come up with a complete set of icons which blend in better. The current icons do not really blend in so well with either gnome-icon-theme or tango theme. AFAIK we could open a bug and just assign it to jimmac, or we could ask diana fong to come up with revised icons. Just my 2 cents Jaap
I think Diana is already on the case. Jimmac is doing suspend/hibernate icons for us I belive, for gnome tangoification.
Created attachment 59784 [details] UPS icons
Created attachment 59785 [details] use this instead
Diana. AFAIK the icons should always be square. The gnome icon theme functions only work with square icons
Yes, agreed. The GNOME HIG people jumped up and down before at the non-square battery icons, hence I had to modify them so that they were square.
What do you mean with square? That the icons are 24x24 or 22x22? If so, which one is it?
(Adding dfong to Cc)
Well at the moment they are 33x22 pixels, i.e. the svg's need to have a 'square' aspect so that 22x22px icons fit in the tray and conform to the HIG.
The GNOME icons need to be 24x24. The new Tango icons are 22x22 but for GNOME a border of 1 pixel is added. So preferably the icons should be like the current ones in CVS 24x24
Created attachment 59863 [details] 24x24
That's brilliant, thanks Diana. Have you go the svg's for those too please, just in case we ever have to add or delete any more icons.
Created attachment 59869 [details] svg
Legend, I'll add these to CVS tonight. Thanks again Diana.
2006-02-25 Richard Hughes <richard@hughsie.com> * data/icons/24x24/*.png, data/icons/svg/*.png, src/gpm-stock-icons.{c|h}, src/gpm-tray-icon.c, src/gpm-manager.c: Add the following icons: ac-adapter, keyboard-power-low, mouse-power-low suspend-to-disk, suspend-to-ram battery-charged, battery-charging-xxx, battery-discharging-xxx ups-charged, ups-charging-xxx, ups-discharging-xxx To rationise our icon naming and make the icon selection *much easier*. This is to address bug #331117 to add new UPS discharging and charging icons, and also to start to fix #331761 so we can theme the icons someday soon. I wanted to do this before the release so we can start working on a default theme.