After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 330789 - gstbaseaudiosink causes noise on seeking
gstbaseaudiosink causes noise on seeking
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-02-11 14:11 UTC by Arwed v. Merkatz
Modified: 2006-02-12 15:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to revert the changes (6.06 KB, patch)
2006-02-11 14:12 UTC, Arwed v. Merkatz 		none Details | Review
remove clipping (794 bytes, patch)
2006-02-12 13:56 UTC, Arwed v. Merkatz 		none Details | Review
fix clipping amount (1.29 KB, patch)
2006-02-12 14:43 UTC, Arwed v. Merkatz 		committed Details | Review

Description Arwed v. Merkatz 2006-02-11 14:11:06 UTC 
Between 0.10.2 and 0.10.3 of gst-plugins-base, baseaudiosink changed and now causes noise after seeking. I tracked it down to the changes done by Wim on 2006-01-25. Reverting those changes removes the noise.
Comment 1 Arwed v. Merkatz 2006-02-11 14:12:42 UTC 
Created attachment 59135 [details] [review]
patch to revert the changes

This reverts the following changes:
2006-01-25  Wim Taymans  <wim@fluendo.com>

        * gst-libs/gst/audio/gstbaseaudiosink.c:
        (gst_base_audio_sink_render), (gst_base_audio_sink_change_state):
        Undo previous commit that returned WRONG_STATE sooner, it breaks 
        resume after pause.

2006-01-25  Wim Taymans  <wim@fluendo.com>

        * gst-libs/gst/audio/gstbaseaudiosink.c:
        (gst_base_audio_sink_setcaps), (gst_base_audio_sink_event),
        (gst_base_audio_sink_preroll), (gst_base_audio_sink_render):
        Improve debugging.
        Post error when caps cannot be parsed.
        Resync on discontinuity in the stream.
        Clip samples to segment boundaries.
        return WRONG_STATE sooner when we are flushing.
Comment 2 Arwed v. Merkatz 2006-02-12 13:56:26 UTC 
Created attachment 59179 [details] [review]
remove clipping

The part causing it is the clipping to the current segment.
Comment 3 Arwed v. Merkatz 2006-02-12 14:43:20 UTC 
Created attachment 59181 [details] [review]
fix clipping amount

The problem is that when clipping happens, the remainder is clipped away instead of the actual clipping amount.
Comment 4 Wim Taymans 2006-02-12 14:58:35 UTC 
Indeed. Fixed in CVS.