After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 330723 - Various components shouldn't include their role in their accessible name.
Various components shouldn't include their role in their accessible name.
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: general
2.6.x
Other All
: Normal normal
: ---
Assigned To: Harish Krishnaswamy
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2006-02-10 21:21 UTC by Rich Burridge
Modified: 2013-09-13 00:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed fix, calendar part (2.75 KB, patch)
2006-02-10 22:17 UTC, Karsten Bräckelmann
committed Details | Review
proposed fix, mail part (3.29 KB, patch)
2006-02-10 22:17 UTC, Karsten Bräckelmann
committed Details | Review
proposed fix, plugins part (1.39 KB, patch)
2006-02-10 22:18 UTC, Karsten Bräckelmann
committed Details | Review
proposed fix, widgets part (3.78 KB, patch)
2006-02-10 22:18 UTC, Karsten Bräckelmann
committed Details | Review

Description Rich Burridge 2006-02-10 21:21:57 UTC
As a followup to bug #330712, we've found several other
places where the accessible name for a widget contains
its role. Listed below are the source filenames where
these string occur, plus the suggested string to use
in its place.

--

./calendar/gui/e-calendar-table.c 
    atk_object_set_name (a11y, _("Task Table"));

Suggest replacing this with "Tasks"

--

./calendar/gui/e-memo-table.c 
    atk_object_set_name (a11y, _("Memo Table"));

Suggest replacing this with "Memos"

--

./calendar/gui/dialogs/comp-editor.c 
  atk_object_set_name (gtk_widget_get_accessible (priv->attachment_expander), _("Attachment Button: Press space key to toggle attachment bar"));

Suggest replacing this with "Show Attachments"

but also adding in an accessible description. In other words,
also add in the line:

  atk_object_set_description (gtk_widget_get_accessible (priv->attachment_expander), _("Press space key to toggle attachment bar"));

--

./mail/em-account-prefs.c 
  atk_object_set_name (gtk_widget_get_accessible (table), _("Mail Accounts Table"));

Suggest replacing this with "Mail Accounts"

--

./mail/em-format-html-display.c 
  atk_object_set_name (a11y, _("Attachment Button"));

Suggest replacing this with "Attachment"

--

  atk_object_set_name (gtk_widget_get_accessible (priv->arrow), _("Toggle Attachment Bar"));

Suggest replacing this with "Show Attachments"

--

./mail/message-list.c 
    atk_object_set_name(a11y, _("Message List"));

Suggest replacing this with "Messages"

--

./plugins/itip-formatter/itip-formatter.c 
  atk_object_set_name (gtk_widget_get_accessible (ess), _("Conflict Search Table"));

Suggest replacing this with "Conflict Search"

--

./widgets/misc/e-calendar.c 
  atk_object_set_name (a11y, _("Previous Button"));

Suggest replacing this with "Previous"

  atk_object_set_name (a11y, _("Previous Button"));

Suggest replacing this with "Previous"

--

./widgets/misc/e-dateedit.c 
  atk_object_set_name (a11y, _("Date and Time Entry"));

Suggest replacing this with "Date and Time"

  atk_object_set_name (a11y, _("Text Date Entry"));

Suggest replacing this with "Date"

  atk_object_set_name (a11y, _("Date Button"));

Suggest replacing this with "Date"

  atk_object_set_name (a11y, _("Time Combo Box"));

Suggest replacing this with "Time"

--

./widgets/misc/e-search-bar.c 
      atk_object_set_name (a11y, _("Search Text Entry"));

Suggest replacing this with "Search"

--

Thanks!
Comment 1 Karsten Bräckelmann 2006-02-10 22:17:08 UTC
Created attachment 59107 [details] [review]
proposed fix, calendar part
Comment 2 Karsten Bräckelmann 2006-02-10 22:17:34 UTC
Created attachment 59108 [details] [review]
proposed fix, mail part
Comment 3 Karsten Bräckelmann 2006-02-10 22:18:04 UTC
Created attachment 59109 [details] [review]
proposed fix, plugins part
Comment 4 Karsten Bräckelmann 2006-02-10 22:18:37 UTC
Created attachment 59110 [details] [review]
proposed fix, widgets part
Comment 5 Rich Burridge 2006-02-10 22:25:30 UTC
Changes look good. Thanks!
Comment 6 Karsten Bräckelmann 2006-02-10 22:29:45 UTC
Committed to HEAD. Sending announcements soon.