After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 330707 - cvs fails to build -- `PR_SET_NAME' undeclared
cvs fails to build -- `PR_SET_NAME' undeclared
Status: RESOLVED FIXED
Product: deskbar-applet
Classification: Deprecated
Component: general
Git master
Other Linux
: Normal normal
: ---
Assigned To: Deskbar Applet Maintainer(s)
Deskbar Applet Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2006-02-10 18:50 UTC by Elijah Newren
Modified: 2006-02-11 12:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
possible fix (4.58 KB, patch)
2006-02-11 01:56 UTC, Danielle Madeley
none Details | Review

Description Elijah Newren 2006-02-10 18:50:11 UTC
_osutilsmodule.c: In function `osutils_set_process_name':
_osutilsmodule.c:39: error: `PR_SET_NAME' undeclared (first use in this function)
_osutilsmodule.c:39: error: (Each undeclared identifier is reported only once
_osutilsmodule.c:39: error: for each function it appears in.)
make[4]: *** [_osutilsmodule.lo] Error 1
make[4]: Leaving directory `/export/home/b/newrenTemp/gnome/deskbar-applet/deskbar/osutils'

I'm on a RHEL4 system compiling from cvs as of today, if that matters.
Comment 1 Raphael Slinckx 2006-02-11 01:24:53 UTC
Hmm, looks like you have the pctrl.h header and function, but not that particular parameter. I assume in the code if HAVE_PCTRL: then use the PR_SET_NAME constant.

Can autotools do a more fine tuned check to see if
pctrl.h,pctrl(),PR_SET_NAME symbols exists ?
Comment 2 Danielle Madeley 2006-02-11 01:56:55 UTC
Created attachment 59118 [details] [review]
possible fix

Elijah,

I think this is the right fix, could you please check it for me and report back?

It should disable prctl() support on your machine when it discovered the PR_SET_NAME define is unavailable.

I had wondered about this define a bit as it is completely undocumented in the manual.
Comment 3 Elijah Newren 2006-02-11 03:56:27 UTC
After applying this patch I get:

_osutilsmodule.c: In function `osutils_set_process_name':
_osutilsmodule.c:45: error: `PyExcPyExc_IOError' undeclared (first use in this function)
_osutilsmodule.c:45: error: (Each undeclared identifier is reported only once
_osutilsmodule.c:45: error: for each function it appears in.)
make[4]: *** [_osutilsmodule.lo] Error 1
make[4]: Leaving directory `/floss/building/gnome/deskbar-applet/deskbar/osutils'

If I s/PyExcPyExc_IOError/PyExc_IOError/ in _osutilsmodule.c, then it builds just fine.
Comment 4 Raphael Slinckx 2006-02-11 12:31:55 UTC
Thanks for the patch. It's comitted in HEAD.
I also applied elijah's fix.