GNOME Bugzilla – Bug 330086
[0.10] non-user friendly error when no dvd support
Last modified: 2007-03-18 23:31:10 UTC
When trying to play a dvd disc with gst-0.10 backend (without dvd support) the users get an error dialog saying: "Totem could not play 'dvd://'. Location not found." The user should know that there is not support for dvd playing on that version of totem, instead that its dvd has not been located.
Yup, the GStreamer backend needs to return FALSE to bacon_video_widget_can_play() for MEDIA_TYPE_DVD
so for gst-0.10 is safe to do this?: diff -u -u -r1.48 bacon-video-widget-gst-0.10.c --- bacon-video-widget-gst-0.10.c 5 Feb 2006 15:46:17 -0000 1.48 +++ bacon-video-widget-gst-0.10.c 6 Feb 2006 09:39:34 -0000 @@ -3200,9 +3200,9 @@ switch (type) { case MEDIA_TYPE_CDDA: case MEDIA_TYPE_VCD: - case MEDIA_TYPE_DVD: res = TRUE; break; + case MEDIA_TYPE_DVD: default: res = FALSE; break;
Yeah, looks good.
Created attachment 58801 [details] [review] Properly check gst-0.10 for dvd playing support
You can check for the presence of a certain elements with if (gst_default_registry_check_feature_version ("foobar", 0, 10, 0)) { .. } but there's more to full DVD support than just having these elements (e.g. the presence of dvdnavsrc doesn't mean that DVD menus will actually work, that requires all elements in the chain to support that). Also, the elements in question are called 'dvdreadsrc' and 'dvdnavsrc' :) For now, totem should probably just return FALSE.
Now totem says "you don't have the necessary plugins installed", which isn't entirely accurate, but still much better than the previous message. 2006-02-06 Tim-Philipp Müller <tim at centricular dot net> * src/backend/bacon-video-widget-gst-0.10.c: (bacon_video_widget_can_play), (bacon_video_widget_get_mrls): Don't claim to be able to play back DVDs when we aren't (for now, at least) (#330086, patch by: Fernando Herrera)
So, since dvdreadsrc has been ported to 0.10 now, can totem be changed to support playing DVDs (without menus) if it's present with gstreamer-0.10?
The DVD stuff isn't robust enough yet for that (seeking is still a bit wonky, no subtitles yet, no menus yet). It will be enabled again as soon as it's in a state where we wouldn't immediately incur hundreds of bug reports from users. For the time being you can watch DVD titles in totem by selecting 'Open Location' and then passing a dvd://<title-number> URI to totem.