After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 329928 - should open external links in web browser
should open external links in web browser
Status: RESOLVED FIXED
Product: devhelp
Classification: Applications
Component: General
git master
Other Linux
: Normal major
: ---
Assigned To: Mikael Hallendal
Mikael Hallendal
Depends on:
Blocks:
 
 
Reported: 2006-02-04 20:34 UTC by Christian Persch
Modified: 2006-02-18 18:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix (30.42 KB, patch)
2006-02-04 21:30 UTC, Christian Persch
none Details | Review

Description Christian Persch 2006-02-04 20:34:32 UTC
Steps:
Choose Gtk FAQ, General, What is gtk, click the "language bindings" link.

Result:
Opens link in devhelp.

Expected result:
Opens link in my preferred web browser.
Comment 1 Christian Persch 2006-02-04 21:30:58 UTC
Created attachment 58719 [details] [review]
fix

The patch adds some more gecko prefs too, and some -D* defines cleanup, and some code fixes in prefs handling copied from yelp. And while I was at it, I made devhelp use the gnome document font gconf key, and HIGified the prefs dialogue.
Comment 2 Richard Hult 2006-02-17 22:44:08 UTC
I guess this will also automagically wil be fixed by this: http://bugzilla.gnome.org/show_bug.cgi?id=324471
Comment 3 Christian Persch 2006-02-18 18:58:37 UTC
Yes, this also fixes bug 324471.

Checked in, except the document font change which turned out to necessitate more changes, which I'll open a separate bug for.