Does the callers of those functions check if -p is used with --profile ?

In that case the profile dir shouldn't be deleted because you might be using a modified dir or an alternative epiphany profile.

Sounds easy to do, can you give me some details about it? :)

Needs to implement ephy_file_delete_directory().

And I'd say we should only delete the profile when using -p without --profile.

Nautilus does this:

		gnome_vfs_async_xfer (&transfer_info->handle, trash_dir_list, NULL,
		      		      GNOME_VFS_XFER_EMPTY_DIRECTORIES,
		      		      GNOME_VFS_XFER_ERROR_MODE_QUERY, 
		      		      GNOME_VFS_XFER_OVERWRITE_MODE_REPLACE,
				      GNOME_VFS_PRIORITY_DEFAULT,
		      		      update_transfer_callback, transfer_info,
		      		      sync_transfer_callback, NULL);

Include this on your patch potential contributor:

Index: src/ephy-main.c
===================================================================
--- src/ephy-main.c     (revision 7227)
+++ src/ephy-main.c     (working copy)
@@ -675,7 +675,7 @@ main (int argc,
 
        if (!ephy_file_helpers_init (profile_directory,
                                     private_instance,
-                                    keep_temp_directory,
+                                    keep_temp_directory || profile_directory,
                                     &error))
        {
                _ephy_dbus_release ();

Created attachment 96275 [details] [review]
There

Should be enough I think.

I think gnome_vfs_xfer_delete_list deletes the directory itself too; so the call to rmdir() in ephy_file_helpers_shutdown could be removed too, right?

Created attachment 96318 [details] [review]
Implements the function and its doc string

You are right about the rmdir, I also added a doc string I hope it's correct.
Btw, I found this while looking for a doc string example...

src/ephy-tab.c:
/**
 * ephy_tab_get_visibility:
 * @tab: an #EphyTab
 *
 * FIXME: Nobody really knows what this does. Someone must investigate.
 *
 * Return value; %TRUE if @tab's "visibility" property is set
 **/

WTF? :)

------------------------------------------------------------------------
r7506 | diegoe | 2007-09-28 16:45:48 -0500 (Fri, 28 Sep 2007) | 6 lines

Implement ephy_file_delete_directory in lib/ephy-file-helpers.c so private
instances of Epiphany remove the profile dir on exit.
Note that the profile dir won't be deleted if it's a custom path.
Fixes bug #329680.