After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 329299 - automatic Landscape/Portrait constraint while cropping
automatic Landscape/Portrait constraint while cropping
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: Editing
CVS
Other All
: Normal enhancement
: ---
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2006-01-31 03:53 UTC by Bengt Thuree
Modified: 2006-10-03 16:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
auto adjustment (2.73 KB, patch)
2006-10-03 11:28 UTC, Stephane Delcroix
committed Details | Review

Description Bengt Thuree 2006-01-31 03:53:20 UTC
As it is now the crop selection specifies 
4 * 3  - Landscape
4 * 6  - Landscape
5 * 7  - Landscape
8 * 10 - Landscape
4 * 3  - Portrait
4 * 6  - Portrait
5 * 7  - Portrait
8 * 10 - Portrait

Would it be possible to only have
4 * 3
4 * 6
5 * 7
8 * 10
etc.
and then while you are selecting the area to be cropped, you should be able to
toggle between Portrait / Landscape mode. Without loosing the size of the rectangle.
Comment 1 Larry Ewing 2006-02-03 03:51:47 UTC
instead of being a toggle I'd prefer it if it would just automatically switch if the box you drag is longer in one dimention than the other.
Comment 2 Bengt Thuree 2006-02-03 04:39:19 UTC
Much better suggestion Larry :)
Comment 3 Marcus Hast 2006-07-24 19:53:09 UTC
Picasa works by automatically changing as one side grows longer. However this has some side effects as sometimes you are trying to finely adjust the cropping when it snaps to the other orientation.

I think an improvement on that would be to have automatic be default but it was possible to lock to a specific format (or current) as well.

Comment 4 David (djst) Tenser 2006-09-09 21:40:30 UTC
The Picasa way is much more intuitive than having to manually select Portrait/Landscape, regardless of the minor side effect Marcus is mentioning.

Is the automatic detection a separate bug report or could this one be morphed to that instead?
Comment 5 Larry Ewing 2006-09-20 18:50:31 UTC
I'll update the description.
Comment 6 Stephane Delcroix 2006-10-03 11:28:20 UTC
Created attachment 73935 [details] [review]
auto adjustment

This patch remove the 'Portrait' cropping options and auto-adapt the crop box depending on the drag movement.
It's quite simple, done in C, and should fix this bug.
Comment 7 Gabriel Burt 2006-10-03 16:04:04 UTC
Committed, thanks Stephane.