After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 329174 - Variable crop area
Variable crop area
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: Editing
CVS
Other All
: Normal enhancement
: ---
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2006-01-30 08:27 UTC by Bengt Thuree
Modified: 2008-03-26 10:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
add-custom-constraint.patch (17.23 KB, patch)
2007-12-26 19:18 UTC, Maxxer
none Details | Review
screenshot of the patch (125.84 KB, image/jpeg)
2007-12-26 19:19 UTC, Maxxer
  Details
add-custom-constraint.patch (17.22 KB, patch)
2007-12-26 19:30 UTC, Maxxer
none Details | Review
add-custom-constraint.patch (17.63 KB, patch)
2008-02-19 20:47 UTC, Maxxer
none Details | Review

Description Bengt Thuree 2006-01-30 08:27:10 UTC
I have some frames at 3.5" * 5", but f-spot have no way of cropping this kind of
measurement.

Would be nice with a Variable selection, and then you can input mm/cm/inch for
Width and Length
Comment 1 Gabriel Burt 2006-01-30 19:53:35 UTC
Or 3.5 x 5 could be added to the constraints list since it is very common.
Comment 2 Bengt Thuree 2006-01-30 23:58:35 UTC
Perhaps I should raise a new bug to add the 3.5 * 5 to the constraints list.
And keep this variable one as an enhancement request.

I saw the following framesizes at http://www.pfile.com/picture-frames/
=======
3.5 * 5
4 * 5
4 * 6
5 * 5
5 * 7
6 * 8
8 * 10
8.5 * 11
8 * 12
9 * 12
10 * 13
10 * 20
11 * 14
11 * 17
12 * 12
12 * 16
12 * 18
13 * 19
16 * 20
18 * 24
========
Either to have all possible frame sizes, or have the most popular ones, and then one variable (which is why I wrote this enhancement bug)
Comment 3 Bengt Thuree 2006-01-31 00:02:30 UTC
I also found 
2.5 * 3.5
3 * 3
4 * 4
8 * 8
Comment 4 Gabriel Burt 2006-01-31 00:25:51 UTC
The whole point is the ratio, so having 4*4 and 8*8 is pointless (especially since there is alredy a square option).  I think adding 3.5x5 and 8.5x11 is a good idea.  The variable option would allow us to keep the list relatively short yet do what some people might need/want.
Comment 5 Bengt Thuree 2006-01-31 00:41:01 UTC
Yes, my point exactly :)
Just thought to list up all the different framesizes I found so we can easily visualize the need. The fixed ones should be easy to add (I can look at that this week), but the variable one needs a input field...
Comment 6 Bengt Thuree 2006-01-31 03:48:33 UTC
We seem to be missing the following options:
3.5 * 5
8.5 * 11

10 * 13
10 * 20  (5 * 10)
11 * 14
11 * 17
13 * 19
16 * 20  (4 * 5)

I can add the 3.5 and 8.5 this week as a patch to a bug I will raise on this.
Comment 7 Bengt Thuree 2006-02-02 10:56:19 UTC
Created a new bug 329581 with attached small patch for adding 3.5*5 and 8.5*11 constraints.
Comment 8 Bengt Thuree 2007-11-26 17:15:30 UTC
Any comments on this enhancement?
I still think it would be nice to have a variable crop area. But if it is not feasable, or whatever, perhaps just close this one, and ensure we get the various constraints we need (as in bug #329581)
Comment 9 Maxxer 2007-12-26 19:18:32 UTC
Created attachment 101635 [details] [review]
add-custom-constraint.patch

Allow the user to add custom constraints for the current session, dropped when F-Spot get closed. 

Very useful for creating Moo cards!! :-)
Comment 10 Maxxer 2007-12-26 19:19:05 UTC
Created attachment 101636 [details]
screenshot of the patch
Comment 11 Maxxer 2007-12-26 19:30:26 UTC
Created attachment 101637 [details] [review]
add-custom-constraint.patch

I checked and rechecked, but yet I missed that one. Replaced "Create" button with stock "Add".
Comment 12 Maxxer 2008-02-19 20:47:42 UTC
Created attachment 105606 [details] [review]
add-custom-constraint.patch

updated to svn.

added a few improvements: 
* appended ratio value to the constraint label
* if a selection exists on the picture, bring the predefined sizes of the dialog from there
Comment 13 Stephane Delcroix 2008-03-20 12:40:23 UTC
maxxer: please keep the user-defined constraints in gconf (using a list)
Comment 14 Stephane Delcroix 2008-03-26 10:23:16 UTC
custom ratios added in r3785