After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 328949 - Hiding/Showing through tray icon suboptimal
Hiding/Showing through tray icon suboptimal
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Other Extensions
git master
Other Linux
: Normal enhancement
: 2.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-01-28 11:11 UTC by Ruben Vermeersch
Modified: 2006-06-03 20:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (1.68 KB, patch)
2006-04-20 08:57 UTC, Przemysław Grzegorczyk
committed Details | Review

Description Ruben Vermeersch 2006-01-28 11:11:15 UTC
Currently, when clicking the tray icon, the following happens:

        private void OnTrayClick(object o, EventArgs args)
        {
            WindowPlayer.Visible = !WindowPlayer.Visible;
            ResizeMoveWindow();
        }

This behavior is fine, but could use some improvements:

 * If banshee is visible, but not on the currently visible desktop, don't hide it, instead show it on the currently visible desktop.
 * If banshee is minimized, don't hide, yet unminimize.
 * If banshee is hidden behind other windows, don't hide, but bring it to the front.

The tray icon behavior would then be the expected "If I see banshee and I click on it, hide it! If I don't see banshee and I click on it, show it!".

Currently the only application that does this right (as far as I know) is gaim, the code for this is here: http://cvs.sourceforge.net/viewcvs.py/gaim/gaim/plugins/docklet/

Will look into this someday in the future (when time permits it), marking it as a gnome-love task for now. If someone is willing to look into this, please do!
Comment 1 Ruben Vermeersch 2006-04-10 18:13:16 UTC
Moving to the Plugins component.

Now relates to the notification area plugin.
Comment 2 Przemysław Grzegorczyk 2006-04-20 08:57:16 UTC
Created attachment 63922 [details] [review]
Proposed patch
Comment 3 Ruben Vermeersch 2006-04-20 09:34:34 UTC
Excellent patch, I like it.
Comment 4 Aaron Bockover 2006-06-03 20:04:56 UTC
I second the excellentness :) Will be committed in my next round.