GNOME Bugzilla – Bug 328938
Need new metaphor for "Disk Mount Applet", Jaz drives are uncommon
Last modified: 2010-01-24 01:05:54 UTC
Please describe the problem: In gnome-applets-2.13.2, the Disk Mounter applet no longer has an icon in the list of applets shown in the "Add to Panel" dialog. If added to the panel, the normal icons for Disk Mounter do appear there. Steps to reproduce: 1. Right-click on panel and click on "Add to Panel" 2. 3. Actual results: Disk Mounter icon in "Add to Panel" dialog is missing Expected results: Disk Mounter icon in "Add to Panel" dialog would be there along with all the others. Does this happen every time? Yes Other information: Gentoo 2005.1/AMD64 I just updated to gnome-panel-2.13.90, but I believe I first noticed this earlier in the day, prior to the panel update.
Pleas See Also bug 328938
Sorry about wrong comment 1 Please See Also bug 328606
Created attachment 58547 [details] [review] A patch to fix it. IMHO the best solution is s/gnome-dev-jazdisk/drive-media-removable. Here is the patch. OK to commit.
Of course I mean "Ok to commit?" BTW, committing the patch, should I've to add a dependence to exact gnome-icon-theme version?
I don't appear to have a drive-media-removable. Is this a Tango change?
Davyd : gnome-icon-themes was changed. soulutions 1, commit patch attachment 58547 [details] [review] 2. gnome-dev-jazdisk is added to icon-naming-utils <icon name="drive-removable-media"> <link>gnome-dev-jazdisk</link> <link>gnome-dev-removable</link> <link>gnome-dev-removable-usb</link> <link>gnome-dev-removable-1394</link> <link>gnome-dev-media-cf</link> <link>gnome-dev-media-memory</link> <link>gnome-dev-media-ms</link> <link>gnome-dev-media-sdmmc</link> <link>gnome-dev-media-sm</link> <link>usbpendrive_unmount</link> </icon> 3. Repair gnome-dev-jazdisk icon again gnome-icon-themes.
Please See : https://bugs.freedesktop.org/show_bug.cgi?id=5794
Ok. I haven't yet updated my gnome-icon-themes. Have all of the separate removable media icons now been lost? That seems a bit disappointing.
> Have all of the separate removable media icons now been lost? > That seems a bit disappointing. Not exactly. The fd.o Icon Naming Specification defines a limited set of useful named icon for toolkits and desktop (and it's still 0.6 :-). But it says also: <quote>The dash “-” character is used to separate levels of specificity in icon names, for all contexts other than MimeTypes. For instance, we use “input-mouse” as the generic item for all mouse devices, and we use “input-mouse-usb” for a USB mouse device. However, if the more specific item does not exist in the current theme, and does exist in a parent theme, the generic icon from the current theme is preferred, in order to keep consistent style.</quote> So we could ask to add a 'drive-media-removable-jazdisk' icon to gnome-icon-theme and use it here, but we should ensure that when your current theme don't provide it, drivemount will use 'drive-media-removable'. I think manage this directly in the applet it's a pain, and should be performed by toolkit. For a list of icon names and appearance, see http://tango-project.org/Tango_Icon_Gallery PS there is a similar issue for mixer applet (see bug # 329521 with similar patch)
Luca, your patch is wrong. The icon is drive-removable-media. Although, I'm not really sure that's the icon that should be used, either. Would be interesting to think of a better metaphor for the applet icon, to show the action of mounting drives somehow, rather than just using a device icon. I think that would be a more optimal solution. As for the drive-removable-media icons, and falling back through them with the "-" separation, as mentioned in the spec, I am not sure it really fits for the removable-media drive icons. They're all basically "drive with big rectangular hole in front". I don't think you can really change that for the extra media types. However, the media-* icons are meant to represent that actual media that one would shove into the drives. This is done to provide separation between the media and drive icons, and allows you to use the media-* icons when media is inserted, and the drive-* icons in Nautilus or wherever, when they aren't.
Created attachment 58638 [details] [review] Use correct icon name (drive-removable-media)
Rodney, I think that by now drive-removable-media is a good _fallback_ icon for this applet. Of course we could also keep the jaz icon and let icon-naming-utils provide it. But in the end should be the same image ;-) About media-* vs drive-removable-media: 1. So, if I like to provide a specific icon for floppy drives (not media, drive) to use for example in computer:// location when the floppy is unmounted, I could add and use a drive-removable-media-floppy icon (imagine a drive with a hole plus a little floppy in front of it, something like MS Window icons). Is it right? 2. As Davyd said, now all removable media icons are lost. Icon naming spec declares only media-floppy and media-cdrom. What should be the proper name for a Jaz media? media-floppy-jaz? And for SD/MMD/xD memory slots? I suspect we can't use media-mmd :-| Is it a bug in icon naming spec?
Don't apply my patch. By now only gnome-icon-theme was ported to icon naming standard. aiiy themes in gnome-themes wasn't.
I just updated to gnome-icon-theme-2.13.5.1 and the Disk Mounter icon is back. However, the Volume Control applet is now missing its icon. This is regardless of whether I use the Gnome icon theme or Tango (my normal icon theme). Is there any reason to file a separate bug for this?
I can confirm that gnome-icon-theme-2.13.7 fixes this -- the Volume Control applet icon is back.
Closing this, it is back.
Reopening. We should look for a better icon metaphor to use for the applet I think, and the mixer applet really should be using the same name as the mixer app. And for 2.15, we want to make them follow the spec. Jaz drives are uncommon. The icon doesn't really help show what the applet does.
I think media-floppy should be used for drive mount, nowdays most of the stuff is automagiacally mounted and a (still) very common device that needs to be mounted manually is the good ol' floppy.
Marking the patch as obsolete. media-floppy is being used now it seems.
My original bug for a missing icon was "hijacked" ;-) to become a Jaz drive icon bug. Since that's been replaced by a floppy icon, I'm going to close this.