After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 328910 - Fit page / Fit width menu items should use bullets
Fit page / Fit width menu items should use bullets
Status: RESOLVED OBSOLETE
Product: evince
Classification: Core
Component: general
0.5.x
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
: 569166 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-01-27 23:31 UTC by Reinout van Schouwen
Modified: 2013-01-07 16:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Reinout van Schouwen 2006-01-27 23:31:25 UTC 
The menu items View->Best Fit and View->Fit Page Width are mutually exclusive. Therefore, they should use bullets and not checkboxes.

Obligatory HIG reference: http://developer.gnome.org/projects/gup/hig/2.0/menus-design.html#menu-item-type-radio
Comment 1 Martin Kretzschmar 2006-01-28 08:54:21 UTC 
And what should we do if neither of them are active? That's not possible with radio button menu items.
Comment 2 Reinout van Schouwen 2006-01-28 12:59:36 UTC 
Isn't it possible to bring the menu item group in a state where neither is selected?
Comment 3 Nickolay V. Shmyrev 2006-02-18 09:56:50 UTC 
I suspect we don't wanna fix that, really they aren't mutually exclusive for the reason Martin provided.
Comment 4 Reinout van Schouwen 2006-02-18 15:44:27 UTC 
I disagree: when one item is checked, the other cannot be checked too. There is an XOR relationship between them, so they are mutually exclusive. This leaves the possibility open for a state where neither is true. 

But does comment 1 indicate this is technically not possible with gtk? In that case I'd think that is a bug in itself.
Comment 5 Wouter Bolsterlee (uws) 2006-10-08 21:54:16 UTC 
It's not XOR, it's NAND (not both) ;) anyway, perhaps a "custom" item would solve this? However, that's quite ugly...
Comment 6 Philip Ganchev 2007-02-22 00:01:21 UTC 
As a third state, use the last zoom level before a change of zoom.  This would also fix another effect of the semantic inconsistency in the interface: selecting "Best fit" twice in a row results in an unchecked box next to the menu entry, but does not change the zoom.
Comment 7 Carlos Garcia Campos 2009-01-26 10:47:08 UTC 
*** Bug 569166 has been marked as a duplicate of this bug. ***
Comment 8 Wouter Bolsterlee (uws) 2009-01-26 10:58:28 UTC 
And what about removing the checkbox/radio button altogether, so that it appears as a regular "action"?
Comment 9 José Aliste 2010-05-04 21:47:57 UTC 
IMO removing checkbox/radio button would not be good. Fit to Page and Fit Width are "constrained zoomed modes" that persist when you resize the window. Maybe, we should have radio buttons with "Free Zoom mode", "Fit to Page", "Fit to Width" and the new "Fit to Text" with a separator between the "free zoom mode" and the rest of the radio buttons.
Comment 10 José Aliste 2013-01-07 16:52:11 UTC 
In Evince 3.8, there are no longer classical manus, but two menus more like in google-chrome (and other new gnome apps) So this bug has become obsolete.