After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 328783 - shift + ctrl + T should not toggle hide/show toolbar
shift + ctrl + T should not toggle hide/show toolbar
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Controls
2.14.x
Other All
: Normal minor
: 2.16.x
Assigned To: Epiphany Maintainers
Marco Pesenti Gritti
: 340176 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-01-27 02:38 UTC by Jon Dufresne
Modified: 2006-08-06 01:02 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Jon Dufresne 2006-01-27 02:38:10 UTC
I use a small keyboard. Very often I will want to open a tab to go to a new
site. I hit ctrl + t to do this. Since my keyboard is small very often I
accidently lean on to the shift as well and before I know it my toolbar is
missing. The first time this happened I didn't know what I just did, and though
I stumbled on a bug. Upon further inspection I realized this was a feature.

I can understand if somoene wants to hide the toolbar, but I don't think it
should be a keyboard shortcut. This isn't the kind of option you are changing
frequently. I looked at Gedit, and it has an option to hide the toolbar but it
isn't linked to a keyboard shortcut, so why should epiphany?

I looked at the HIG here
http://developer.gnome.org/projects/gup/hig/2.0/toolbars-controlling-display.html

it mentions allowing hides, but doesn't say to include a keyboard shortcut.


I find it does more harm then good.

Other information:
This is using epiphany 1.8.2
Comment 1 Reinout van Schouwen 2006-01-28 22:34:09 UTC
Thanks for your bug report. I can see how this shortcut could pose a problem. As a workaround, enable Editable menu accelerators in the GNOME menu and toolbar preferences; then highlight the Toolbar menu item in the View menu and press your desired shortcut, or Backspace if you just want to delete it.

Note: evince is also using this keyboard shortcut.
Comment 2 Reinout van Schouwen 2006-02-02 20:40:14 UTC
harves, how about using a different shortcut? Ctrl+K doesn't seem to be in use yet... We could reserve the Ctrl+Shift+char shortcuts for those cases where we want the reverse action of what Ctrl+char would have done.
Comment 3 Crispin Flowerday (not receiving bugmail) 2006-02-03 10:58:03 UTC
Ctrl+K is used by FireFox for going to the google search box, it might be confusing for people changing if that toggles a toolbar instead.
Comment 4 Reinout van Schouwen 2006-05-03 10:15:34 UTC
*** Bug 340176 has been marked as a duplicate of this bug. ***
Comment 5 Reinout van Schouwen 2006-05-03 10:18:34 UTC
How about Ctrl+J? There aren't much free combinations left...
Comment 6 Reinout van Schouwen 2006-07-14 20:37:14 UTC
Any objections to Ctrl+J? This can't be more than a trivial fix.
Comment 7 Christian Persch 2006-07-14 20:47:14 UTC
How about not using any shortcut?
Comment 8 Jon Dufresne 2006-07-14 21:20:30 UTC
I also feel no shortcut is the best solution. This doesn't seem like something users are toggling often so what is the point of a shortcut key if it only confuses people.
Comment 9 Reinout van Schouwen 2006-07-15 09:29:34 UTC
OK with me.
Comment 10 Alan Horkan 2006-07-27 02:04:51 UTC
> How about Ctrl+J? There aren't much free combinations left...

Ctrl+J is used in Firefox to show the Download manager.  

> This isn't the kind of option you are changing frequently. 

Toolbars are not something you _should_ need to toggle frequently (and for most users I expect toggling Fullscreen mode is a reasonable enough workaround to achieve similar results of temporarily getting rid of the toolbars).  

> How about not using any shortcut?

No shortcut seems like the best default in this case.  Ctrl+t for new tab seems like a very frequently used shortcut and all too easy to trigger this one accidentally.  Also the workaround suggested above to clear a shortcut should work to add one in if a user feels they really needs to add a shortcut back in.  

> Note: evince is also using this keyboard shortcut.

I'll bet* Evince used Epiphany as an excuse for adding that shortcut

* no actual cash money
Comment 11 Christian Persch 2006-08-05 20:17:12 UTC
I removed the accel. Someone please file a bug for evince to do the same.
Comment 12 Jon Dufresne 2006-08-06 01:02:37 UTC
Done, bug 350110