GNOME Bugzilla – Bug 328732
When try to copy a blank volume, size is incorrect
Last modified: 2006-05-19 15:31:52 UTC
1. Insert a blank DVD 2. Run nautilus-cd-burner --source-device=/dev/device 3. "Data size: $CAPACITY_OF_A_DVD" is shown It should tell the user that the disk is blank, instead.
*** Bug 332647 has been marked as a duplicate of this bug. ***
Created attachment 65605 [details] [review] Patch for this bug This should bring order to the capacity/size ambiguity (and changes the API a little)
That looks pretty good. Do you think we need NAUTILUS_BURN_MEDIA_SIZE_BLANK or can we just return zero for that? Also, this change pretty much implies requiring HAL I think. It is becoming increasingly difficult to do things correctly (and without reinventing the wheel) without HAL.
Yes, I forgot to mention that this depends on HAL because I don't provide a non-HAL fallback. I think that returning zero is ok. Thanks for the fast review.
Created attachment 65825 [details] [review] Patch Updated patch without NAUTILUS_BURN_MEDIA_SIZE_BLANK.
I've committed this with a few changes. * get_media_capacity didn't actually get the capacity but the size * fix a compiler warning about an uninitialized value * there were tabs introduced to the spacing in nautilus-burn-drive.h * use the new API in list_cddrives * bump the LT_VERSION since we break the API I'll patch rhythmbox to support this new API. Thanks Fabio. 2006-05-19 William Jon McCann <mccann@jhu.edu> * src/list_cddrives.c (list_media_info, display_size): Use both capacity and size API. * configure.in: Bump LT_VERSION since we break API. * src/nautilus-burn-drive.c: (nautilus_burn_drive_get_media_capacity_from_path), (nautilus_burn_drive_hal_get_media_capacity), (nautilus_burn_drive_get_media_size), (nautilus_burn_drive_get_media_capacity), (nautilus_burn_drive_nohal_is_mounted): * src/nautilus-burn-drive.h: * src/nautilus-burn-recorder.c: (nautilus_burn_recorder_wait_for_insertion): * src/ncb-operation.c: (request_media): * src/ncb-selection.c: (verify_device): Rename drive_get_media_size to get_media_capacity because that is what it actually is. Add a new drive_get_media_size that reports the data size of the volume. Patch from Fabio Bonelli <fabiobonelli@libero.it> Fixes #328732
*** Bug 341179 has been marked as a duplicate of this bug. ***