GNOME Bugzilla – Bug 328725
Add "Find in this folder" feature through typeahead enhancement
Last modified: 2012-08-24 20:43:12 UTC
Initial patches and comments of this feature are in bug 325086, now moved to here, here is a description of the feature: Hi, the current nautilus search feature is very powerful but at the same time is too complicated[1] for simple, quickly searches in the current browsed directory, e.g. you've just downloaded a file and wants to locate it in your pretty full "Downloads" folder. To solve that I made a nautilus-findbar[2] patch a while ago but it was also too complicated for the matter and I was told by Alex that for that purpose it was better to just enhance the existent typeahead feature to also look at middle of strings, and so this patch does the following for both icon and list view: - Makes the Interactive search (aka typeahead) accesible from the Edit menu. - Makes the typeahead search at middle of strings. The patch is for spatial window atm. [1] Requires opening an external window and entering search parameters, which is needed for a general/powerful search. [2] http://supertux.cenobioracing.com/nautilus.html
Created attachment 58150 [details] [review] new version of patch This new version has fixed all issues reported by Alex on this email: http://mail.gnome.org/archives/nautilus-list/2006-January/msg00103.html
+ { "Interactive Search", GTK_STOCK_FIND, N_("_Find in this folder"), + "<control>Z", N_("Find files in this folder"), Ctrl-Z is Undo in most apps, and in HIG... I realise it's going to be difficult to find an unused accel for this :/
Created attachment 58332 [details] [review] Improved patch Changes from previous patch: - Remove unnecessary FMDirectoryView code as it is not needed to implement NautilusView methods. - Use CTRL-J as shortcut, this time I verified it against HIG shortcuts[1] and nautilus. - Remove commented code left by mistake in previous patch. [1] http://developer.gnome.org/projects/gup/hig/1.0/userinput.html
Absolutly loving this patch, I've been working with a lot of big directories where the filenames are very similar lately, and it's been a pain. But I'm wondering, it might be possible to implement this without a seperate find option, by building it into the typeahead find? Start typing and nautilus will show that menu, maybe it'd be possible to add the "case sensitive" checkbox to that menu, and allow pattern matching in there? So "x" will not match "abcx", but "*x" will.
Is Ctrl+K already taken? That's the shortcut used by Gedit for the "interactive search" menu item, so that would seem like an obvious choice to me.
Old patch with no updates for a long time. I'm closing as incomplete. Please let me know if I've got it wrong. :)
No, we should not close this kind of bugs as INCOMPLETE; what we want is to find out whether this is a feature we want and update the patch in case.
(In reply to comment #7) > No, we should not close this kind of bugs as INCOMPLETE; what we want is to > find out whether this is a feature we want and update the patch in case. My bad. Thanks for picking me up on that, Cosimo. I generally like this proposal. Would it replace the functionality provided by the select pattern matching dialog? If it does, this bug is a dupe of bug 532851. There are a couple of potential problems though: 1. Type-ahead find should be consistent across GNOME. Does this approach mean we break consistency? 2. Bug 612675 requests that type-ahead find cycles through matching patterns (for a11y reasons). That would seem to be incompatible with this bug. One potential solution is to merge the 'select matching pattern' dialog into the toolbar (as requested in bug 417582) and to add the desired functionality there.
Switching component to type-ahead find for now.
*** This bug has been marked as a duplicate of bug 115926 ***