After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 328723 - long file names in the download manager don't get shortened
long file names in the download manager don't get shortened
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Downloads
1.9.x
Other All
: Normal trivial
: 2.14.x
Assigned To: Epiphany Maintainers
Marco Pesenti Gritti
Depends on:
Blocks:
 
 
Reported: 2006-01-26 13:13 UTC by Alexander van Loon
Modified: 2006-02-26 21:09 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

Attachments
the "ellipsize" property for 2nd column of Downloads window (1.25 KB, patch)
2006-02-20 20:15 UTC, Sergey Al. Safonov 		none Details | Review
i have changed _ellipsize_end to _ellipsize_middle. (1.26 KB, patch)
2006-02-20 20:31 UTC, Sergey Al. Safonov 		none Details | Review

Description Alexander van Loon 2006-01-26 13:13:30 UTC 
Please describe the problem:
Long file names in the download manager don't get shortened, which
makes a scroll bar appear so that I can't see the time remaining.
Screenshot here: http://www.xs4all.nl/%7Evanlonen/epiphany_download.jpg

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Christian Persch 2006-02-12 21:36:23 UTC 
I think we could just ellipsise the string... middle or end?
Comment 2 Crispin Flowerday (not receiving bugmail) 2006-02-12 21:40:16 UTC 
middle, that way we get the file extension showing
Comment 3 Sergey Al. Safonov 2006-02-20 20:15:15 UTC 
Created attachment 59787 [details] [review]
the "ellipsize" property for 2nd column of Downloads window

I have written patch that set "ellipsize" property to the second column of Download window. It should work, if not, tell me.
Comment 4 Sergey Al. Safonov 2006-02-20 20:20:23 UTC 
Comment on attachment 59787 [details] [review]
the "ellipsize" property for 2nd column of Downloads window

>Index: ChangeLog
>===================================================================
>RCS file: /cvs/gnome/epiphany/ChangeLog,v
>retrieving revision 1.3059
>diff -u -p -r1.3059 ChangeLog
>--- ChangeLog	20 Feb 2006 19:23:20 -0000	1.3059
>+++ ChangeLog	20 Feb 2006 20:10:42 -0000
>@@ -1,3 +1,10 @@
>+2006-02-20  Sergey Al. Safonov  <spoof@spoofa.info>
>+
>+	* embed/downloader-view.c: (downloader_view_build_ui):
>+	
>+	Ellipsize second column for download window. 
>+	Fix for the bug #328723
>+
> 2006-02-20  Christian Persch  <chpe@cvs.gnome.org>
> 
> 	* embed/mozilla/GtkNSSSecurityWarningDialogs.cpp:
>Index: embed/downloader-view.c
>===================================================================
>RCS file: /cvs/gnome/epiphany/embed/downloader-view.c,v
>retrieving revision 1.92
>diff -u -p -r1.92 downloader-view.c
>--- embed/downloader-view.c	2 Feb 2006 17:27:40 -0000	1.92
>+++ embed/downloader-view.c	20 Feb 2006 20:10:42 -0000
>@@ -662,6 +662,7 @@ downloader_view_build_ui (DownloaderView
> 					    "pixbuf", COL_IMAGE,
> 					    NULL);
> 	renderer = gtk_cell_renderer_text_new ();
>+	g_object_set (renderer, "ellipsize", PANGO_ELLIPSIZE_MIDDLE, NULL);
> 	gtk_tree_view_column_pack_start (column, renderer, TRUE);
> 	gtk_tree_view_column_set_attributes (column, renderer,
> 					     "text", COL_FILE,
Comment 5 Sergey Al. Safonov 2006-02-20 20:31:46 UTC 
Created attachment 59789 [details] [review]
i have changed _ellipsize_end to _ellipsize_middle.
Comment 6 Christian Persch 2006-02-26 21:09:04 UTC 
Checked in; thanks for the patch!