After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 327777 - Add --without-alsa switch to configure
Add --without-alsa switch to configure
Status: VERIFIED FIXED
Product: GIMP
Classification: Other
Component: General
git master
Other Linux
: Normal enhancement
: 2.4
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2006-01-20 00:02 UTC by Henrik Brix Andersen
Modified: 2006-01-20 11:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (905 bytes, patch)
2006-01-20 00:03 UTC, Henrik Brix Andersen 		none Details | Review

Description Henrik Brix Andersen 2006-01-20 00:02:26 UTC 
In order to be able to compile GIMP on a box with alsa-lib installed, and later deploy it on a box without alsa-lib, a configure switch for disabling ALSA support in the midi input controller is needed.
Comment 1 Henrik Brix Andersen 2006-01-20 00:03:20 UTC 
Created attachment 57681 [details] [review]
Proposed patch
Comment 2 Michael Natterer 2006-01-20 09:20:56 UTC 
Did you try this patch? It replaces an AC_DEFINE by an AM_CONDITIONAL,
which takes away the possibility to #ifdef HAVE_ALSA

Apart from that, I agree it should be configurable.
Comment 3 Henrik Brix Andersen 2006-01-20 09:38:14 UTC 
(In reply to comment #2)
> Did you try this patch? It replaces an AC_DEFINE by an AM_CONDITIONAL,
> which takes away the possibility to #ifdef HAVE_ALSA

Yes, I've tested --with-alsa and --without-alsa, followed by calling ldd on libcontroller_midi.so. Didn't notice any warnings caused by #ifdef HAVE_ALSA.

That being said, you're much more experienced in autoconf syntax than I am :)
Comment 4 Michael Natterer 2006-01-20 09:50:32 UTC 
Yes, it does compile for both --with and --without, but it never
uses alsa, it just links against the lib :)
Comment 5 Michael Natterer 2006-01-20 10:46:20 UTC 
Fixed in CVS:

2006-01-20  Michael Natterer  <mitch@gimp.org>

	* configure.in: applied modified patch from Henrik Brix Andersen
	which adds the possibility to build --without-alsa, even if alsa
	is available. Fixes bug #327777.
Comment 6 Henrik Brix Andersen 2006-01-20 11:17:19 UTC 
Verified, thanks.