GNOME Bugzilla – Bug 326692
Extra comma in between mail ids when mail id selected from 'Select contacts' UI
Last modified: 2013-09-14 16:52:52 UTC
While composing mail, selected first mail id for 'To' field from 'autocompletion' list. Next click on 'To' button, select Conatcts from Addressbook' popsup. In that select an id, and close it. Observe there are two commas in between two mail ids. If both the ids are selected from 'Select contacts addressbook' the extra comma is not reproducible.
Confirming it as it is always reproducible
confirming, still in 2.7.92
Bumping version to a stable release.
Created attachment 117441 [details] [review] proposed eds patch for evolution-data-server; I investigated this and in actual version the selector dialog shows some fake destination "<?>" in it after completion. I believe the core issue is the same. As far as I can tell, the problem is that last ", " added at the end of the entry text when done with autocompleting. This adds also a fake destination to the destination store, just to have one ready to update when user types. The patch just adds a sanitizing of the store on the focus_out event, by removing those fake destinations. The side-effect of this patch is also that when someone sees "ENameSelectorEntry is out of sync with model!" on the console, then just go to the other widget synchronizes it and user can see what will be used. This is a good side-effect, I hope.
Just one note, I believe better solution would be to commit patch from bug #272391 and instead of playing with ranges and trying to get destination description from the field text simply use get_destination_textrep introduced there. I'll rewrite patch when/if the second one will be approved.
Milan, bug #272391 has some UI freeze elements. In which case, you can commit it for trunk for 2.23.91. REwork and commit for 2.25.x later.. sounds fine?
Patch committed to SVN trunk as r1766 http://svn.gnome.org/viewvc/evolution-exchange?view=revision&revision=1766 Bug to be closed after string-change is announced.
oops.. sorry for the spam - comment #7 was for bug #549228
(In reply to comment #6) > Milan, bug #272391 has some UI freeze elements. In which case, you can commit > it for trunk for 2.23.91. REwork and commit for 2.25.x later.. sounds fine? Yup, will rework later today, the eds part from bug #272391 has been committed to trunk, so I will just update this patch and commit.
Modified patch committed to trunk. Committed revision 9461. I marked this as obsolete because of the change.