GNOME Bugzilla – Bug 326679
The New Sound Capplet UI
Last modified: 2009-01-30 12:04:16 UTC
I have a few comments pertaining to the new sound capplet UI. 1. Alignment of the labels - the HIG prefers left aligned labels. 2. Category contents is not indented - the HIG states that the contents be indent by 12 pixels. 3. Spacing between the rows and columns under System Sounds - the HIG recommends 6 pixels between rows. Combobox labels should be 12 pixels from their combobox widget. Others typically use 6 pixels. 4. Mnemonic conflicts - the dialog has conflicting mnemonics for S, C, & L. 5. The dialog will not fit on 800x600 display.
Created attachment 57187 [details] [review] Proposed patch This patch addresses issues 1 thru 3 from above. 2006-01-11 Dennis Cranston <dennis_cranston@yahoo.com> * capplets/sound/sound-properties-capplet.c: (create_dialog): Do not hardcode the height of the dialog. * capplets/sound/sound-properties.glade: Add an alignment to set 18 pixels of space before starting the "System Sounds" category. * libsounds/sound-view.c: (play_preview_cb), (add_sound_item), (sound_view_init): Indent the contents of the "System Sounds" category. Use left alignment for combobox labels. Fix the row and column spacing.
Created attachment 57188 [details] Screenshot of changes
Ok, patch will be committed to HEAD soon, thanks. That leaves us 2 issues, 4. Mnemonic conflicts - the dialog has conflicting mnemonics for S, C, & L. 5. The dialog will not fit on 800x600 display.
Created attachment 57265 [details] [review] Proposed patch I previously overlooked the use of the volume icon for previewing the sound files. The media-play icon is more appropriate here.
Created attachment 57266 [details] [review] The correct proposed patch
I don't think we want the label in those buttons, so have changed your patch to: Index: sound-view.c =================================================================== RCS file: /cvs/gnome/libsounds/libsounds/sound-view.c,v retrieving revision 1.29 diff -u -p -r1.29 sound-view.c --- sound-view.c 12 Jan 2006 12:55:38 -0000 1.29 +++ sound-view.c 18 Jan 2006 15:16:09 -0000 @@ -249,6 +249,7 @@ add_sound_item (GtkTable *table, SoundVi { GtkWidget *label; GtkWidget *combo; + GtkWidget *play_button; gint index; ComboBoxEntryInfo *info; @@ -305,8 +306,9 @@ add_sound_item (GtkTable *table, SoundVi 1, 2, table->nrows - 1, table->nrows, GTK_EXPAND | GTK_FILL, GTK_SHRINK, 0, 3); - GtkWidget *play_button = gtk_button_new(); - gtk_container_add (GTK_CONTAINER (play_button), gtk_image_new_from_stock (GNOME_STOCK_VOLUME, GTK_ICON_SIZE_SMALL_TOOLBAR)); + play_button = gtk_button_new (); + gtk_container_add (GTK_CONTAINER (play_button), + gtk_image_new_from_stock (GTK_STOCK_MEDIA_PLAY, GTK_ICON_SIZE_SMALL_TOOLBAR)); g_signal_connect (G_OBJECT(play_button), "clicked", (GCallback) play_preview_cb, info); gtk_table_attach (GTK_TABLE (table), play_button,
This was raised in https://launchpad.net/distros/ubuntu/+source/gnome-applets/+bug/29045 as well.
I raised bug 330593 for the mnemonic conflicts
Created attachment 59741 [details] mockup_sound_groups.png wrt the dialog size, what about grouping sounds in category, organizing them with expanders (maybe inside a vertically scrollable window)? I understand this might not be the best solution, but it should reduce the dialog size, making it usable also with low resolutions. Of course dialog boxes should all be the same size, not like in my mockup :)
We already have a better UI in the control-center for GNOME 2.24 and gnome-media for 2.25.