After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 326256 - change all "Addressbook" to "Address Book"
change all "Addressbook" to "Address Book"
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.4.x (obsolete)
Other Linux
: Normal minor
: ---
Assigned To: André Klapper
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2006-01-09 01:59 UTC by Karsten Bräckelmann
Modified: 2006-02-05 23:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (1.45 KB, patch)
2006-01-20 19:26 UTC, oswald
committed Details | Review
proposed fix, continued (5.76 KB, patch)
2006-02-05 22:10 UTC, Karsten Bräckelmann
none Details | Review
proposed fix, continued (7.54 KB, patch)
2006-02-05 22:17 UTC, Karsten Bräckelmann
committed Details | Review

Description Karsten Bräckelmann 2006-01-09 01:59:55 UTC
There is a typo in the right-click context menu for email addresses in the mail pane. "Add to Addressbook" should be corrected to "Add to Address Book".

Steps to reproduce:
* Display a mail.
* right-click any email address in the header
Comment 1 Poornima 2006-01-09 09:57:51 UTC
Minor fix, confirming bug.
Comment 2 oswald 2006-01-20 19:26:45 UTC
Created attachment 57745 [details] [review]
patch

Changed 'Add to Addressbook' to 'Add to Address Book'
Comment 3 André Klapper 2006-01-22 16:49:47 UTC
we should grep the entire code base for user-visible "addressbook" strings. i've seen more already.
Comment 4 André Klapper 2006-01-26 16:17:53 UTC
oswald: thanks for committing the patch, i have committed it:
http://cvs.gnome.org/viewcvs/evolution/mail/em-popup.c?r1=1.39&r2=1.40
http://cvs.gnome.org/viewcvs/evolution/mail/ChangeLog?r1=1.3780&r2=1.3781

leaving this bug open since i haven't grepped the rest of the codebase
Comment 5 André Klapper 2006-01-26 16:18:54 UTC
...and rephrasing the summary
Comment 6 Karsten Bräckelmann 2006-02-05 22:07:21 UTC
Andre, please take care about the attachments status. ;-)
Comment 7 André Klapper 2006-02-05 22:08:23 UTC
uhm, you're right
Comment 8 Karsten Bräckelmann 2006-02-05 22:10:33 UTC
Created attachment 58785 [details] [review]
proposed fix, continued

This patch hopefully takes care about any left Addressbook string taht is marked for translation.

Note: This patch does not change the translatable strings in:
addressbook/gui/component/GNOME_Evolution_Addressbook.server.in.in.h
Comment 9 Karsten Bräckelmann 2006-02-05 22:17:36 UTC
Created attachment 58786 [details] [review]
proposed fix, continued

This time with the .server.in.in name strings.
Comment 10 André Klapper 2006-02-05 23:01:28 UTC
yay. go ahead with comment #8. dunno about comment #9. tia.
dumdidum.
Comment 11 Karsten Bräckelmann 2006-02-05 23:11:21 UTC
These patches should fix this bug. Please review and let me know if I may commit it.

Please note that we are in String Announcement period. Raising Priority temporarily to speed things up. String Freeze is just a couple of days ahead.
Comment 12 Karsten Bräckelmann 2006-02-05 23:49:15 UTC
OK, I went ahead and committed the patch.

I believe the translated .server strings are just the names displayed in the bonobo-browser. Plus, they actually are translated, at least in German. :)


This should fix all instances of Address Book, closing.