After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 326103 - allow to install a theme from a directory
allow to install a theme from a directory
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] theme-manager
2.13.x
Other Linux
: Normal enhancement
: ---
Assigned To: Thomas Wood
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-01-07 14:02 UTC by Sebastien Bacher
Modified: 2006-12-03 14:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Path #1 (27.02 KB, patch)
2006-01-08 14:31 UTC, Thomas Wood 		needs-work Details | Review
Patch #2 (6.46 KB, patch)
2006-01-09 21:15 UTC, Thomas Wood 		none Details | Review

Description Sebastien Bacher 2006-01-07 14:02:08 UTC 
This bug has been described on http://bugzilla.ubuntu.com/show_bug.cgi?id=18152

"Using the theme preferences, you can drag and drop a theme archive onto the
theme preferences window, and it will confirm the path and install it.

Doing this same operation with a theme archive that has already been extracted
confirms the path and then results in the error message "The file format is
invalid".

This seems extremely silly and a friend that just installed Linux just bumped
into it as he was trying to install a theme.  He went through about 6 of them
before he immed me, and then I had to till him exactly what I was doing for him
to figure it out.  Seems like a usability problem to me.
...
> Thanks for your bug. What version of Ubuntu do you use? What kind of theme do
you install? I've just tried with an icon theme, it opens a dialog saying it has
been installed correctly.
...
OK I just tried it with a GTK theme, Metacity theme, and an icon theme.

All were unsuccesfull when I first uncompressed them, dragged the directory to
the Theme Preferences window, and confirmed the path. Attempting to install them
this way resulted in the error "The file format is invalid".  "
Comment 1 Thomas Wood 2006-01-08 14:31:04 UTC 
Created attachment 56966 [details] [review]
Path #1

The patch allows theme directories to be installed via the theme manager.
Comment 2 Sebastien Bacher 2006-01-08 21:09:21 UTC 
Thanks for your work on that. Is that an indentation fix patch or a bug fix one? :) Could you split the patch in 2 parts, one for all the indentation fixes and one with the actual code change?
Comment 3 Sebastien Bacher 2006-01-08 21:26:14 UTC 
Out of the indentation changes noise the patch seems to be fine
Comment 4 Thomas Wood 2006-01-09 12:28:43 UTC 
Sorry, I meant to apologise for the indentation stuff. I want to fix some other issues after this one, so was tidying it up at the same time. I can create a patch ignoring white space if you want.
Comment 5 Rodrigo Moya 2006-01-09 12:31:08 UTC 
yes, please
Comment 6 Thomas Wood 2006-01-09 21:15:15 UTC 
Created attachment 57064 [details] [review]
Patch #2

Diff with -w (Ignore all white space)
Comment 7 Thomas Wood 2006-01-11 14:01:13 UTC 
It should be noted that most of the new indentation is caused by the fact that large parts of the code are now contained in if() blocks (all the gzip/bzip testing and extracting is not needed for directories).

Are there any more comments on the patch?
Comment 8 Thomas Wood 2006-12-03 14:58:21 UTC 
I've just committed a new implementation of this to CVS HEAD.