After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 325705 - Menu items aren't displayed in localized string
Menu items aren't displayed in localized string
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: general
git master
Other Linux
: Normal major
: 2.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-01-04 00:16 UTC by Koike Kazuhiko
Modified: 2006-01-14 18:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot(Japanese) (44.47 KB, image/png)
2006-01-04 00:17 UTC, Koike Kazuhiko 		  Details
test patch (1.32 KB, patch)
2006-01-14 06:03 UTC, Koike Kazuhiko 		none Details | Review

Description Koike Kazuhiko 2006-01-04 00:16:17 UTC 
Menu items aren't displayed in localized string.

Only "Rename Playlist" in Edit menu is displayed correctly.
Comment 1 Koike Kazuhiko 2006-01-04 00:17:14 UTC 
Created attachment 56746 [details]
Screenshot(Japanese)
Comment 2 Aaron Bockover 2006-01-04 01:48:03 UTC 
All the strings for menus and other interfaces are wrapped in Catalog.GetString() for gettext to work. The Japanese translation just hasn't been updated to reflect recent changes. I'm closing as I don't think this is a real bug, thanks.
Comment 3 Koike Kazuhiko 2006-01-04 02:01:17 UTC 
I'm a translater of ja.po. What should I do?
All strings of menu items have been already translated.
Comment 4 Koike Kazuhiko 2006-01-14 05:59:00 UTC 
I believe this is a bug. Reopening.
Comment 5 Koike Kazuhiko 2006-01-14 06:03:50 UTC 
Created attachment 57327 [details] [review]
test patch

All of Localized strings are displayed if you apply this patch.
I can't explain why this patch works.
Comment 6 Koike Kazuhiko 2006-01-14 06:10:06 UTC 
Only "Rename Playlist" is displayed in the localized string when launched,
because the label text is overwritten by PlayerUI.SensitizeActions().

And if you hit Play button, [Playback] - [Pause] is changed to the localized
string.
Comment 7 Aaron Bockover 2006-01-14 18:55:34 UTC 
Excellent. So while the patch does work, it's not necessary, but it helped me find why the weird fix did work. Basically the gettext catalog was not being initialized until the interface was created, but the actions were created before that. The catalog is now initialized in the static Globals class, and the menus are now properly translated.

Thanks!