GNOME Bugzilla – Bug 325264
Allow entry of year
Last modified: 2008-01-11 15:52:27 UTC
Currently there is no way to insert the release year of an album in the sj ui. The Genre field could be split to make place for this. I realize that there are many more fields that are missing, but I think that this is one really important piece of information that you have already given on the cover of the cd you are about to rip if not provided by musicbrainz. Other information:
I'm more inclined to get people to populate MusicBrainz, rather than have fields for every item of metadata people could want.
It seems that MusicBrainz does have the year for a particular CD, but it somehow doesn't get encoded into the track. Case in point: The Chemical Brothers album "Surrender" has year information: http://musicbrainz.org/album/8268c2f8-bfc3-4079-9c25-fad0d69a38df.html But after encoding this via sound-juicer-2.10.1-1 (FC4), there is no year information in the resulting mp3 file: $ id3info 01\ Music\:\ Response.mp3 *** Tag information for 01 Music: Response.mp3 === TIT2 (Title/songname/content description): Music: Response === TPE1 (Lead performer(s)/Soloist(s)): The Chemical Brothers === TALB (Album/Movie/Show title): Surrender === TRCK (Track number/Position in set): 1 *** mp3 info MPEG1/layer III Bitrate: 32KBps Frequency: 44KHz
SJ 2.10 doesn't add the year, you need 2.12.
While getting MusicBrainz populated is good, one issue is that you can't tell whether MB gave S-J year information or not, since it isn't displayed anywhere.
SJ 2.14.3 doesn't add the year neither. And I don't know (viewing the UI) how to set it up to get it done.
SJ will add the year info if and only if there is release information in MusicBrainz. If this is set, it will write the metadata. If your encoder supports the tags, they will be written. Note that this generally means using Ogg as GStreamer's MP3 tag writing support is lame (boom boom).
Created attachment 102592 [details] [review] Add year entry This patch adds year entry to the UI.
I'll give it a test in a minute, but when the date field is changed don't free the existing release GDate unless you've parsed a valid date from the entry. Apart from that, great!
Oh, and you can use gtk_entry_get_text (GTK_ENTRY (editable)) instead of gtk_editable_get_chars().
In testing I discovered that patch was crashing, so I fixed the bug (double-free) and committed. Thanks!