GNOME Bugzilla – Bug 325176
improved glowing
Last modified: 2006-07-03 17:05:46 UTC
The attached patch adds some options for themes to change how the glowing is done. The main changes are that themes can either just choose one/two color(s) (changed the default colors to base[SELECTED] for the glowing) or use the button drawn in a different state. Furthermore it is possible to change the loop time and the final opacity of the colors/buttons. This means that themes can pretty much change the animation to whatever they want. The patch works by adding a few style properties (the names/descriptions could use some improvements) WnckTasklist::fade-loop-time: time for one iteration WnckTasklist::fade-using-style: whether to use colors or drawn buttons WnckTasklist::fade-color1: first color WnckTasklist::fade-color2: second color WnckTasklist::fade-state1: The state used for drawing the first button WnckTasklist::fade-state2: The state used for drawing the second button WnckTasklist::fade-opacity: The final opacity reached.
Created attachment 56482 [details] [review] patch
The patch is also an improvment over the current code, because the color of the icon does not change at all.
Thanks for the patch. Can you attach it in the "diff -u" format?
Created attachment 56587 [details] [review] patch in diff -u format
Created attachment 56592 [details] video showing of the animation using the eXperience theme The animation seems to be faster in the video than it is in reality. But as this is configurable by the theme it is really not a big deal.
I committed a slightly modified version. Enjoy.
OK, as discussed, here a new proposal for a bunch of style properties: WnckTasklist::fade-loop-time: time for one iteration WnckTasklist::fade-iterations: iterations till the animation stops (-1 to never stop) WnckTasklist::fade-overlay-rect: Use an overlay rectangle instead of modifing the button background. WnckTasklist::fade-opacity: The final opacity reached. The idea is to use bg[SELECTED] as the color for fading. The fade-overlay-rect style property needs to be provided for compatibility with pixbuf based themes that cannot react to changed style colors. Patch will hopefully follow soon :-)
Benjamin: I believe it'd be better to open a new bug for the patch ;-)