After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 325143 - View/Save attachments in PDF
View/Save attachments in PDF
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
unspecified
Other All
: Normal enhancement
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-12-28 14:07 UTC by Troy Henderson
Modified: 2006-05-26 16:48 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
PDF containing 2 JPEG attachments (26.56 KB, application/pdf)
2005-12-28 14:09 UTC, Troy Henderson
  Details
Proposed patch (59.95 KB, patch)
2006-04-02 18:29 UTC, Carlos Garcia Campos
committed Details | Review
Allow multiple selection (16.40 KB, patch)
2006-04-29 18:34 UTC, Carlos Garcia Campos
committed Details | Review

Description Troy Henderson 2005-12-28 14:07:00 UTC
PDF's can actually contain attached files of any filetype.  This message is to
request Evince to be able to View/Save these attachments.  The following message
will provide an example PDF with 2 JPEG attachments.
Comment 1 Troy Henderson 2005-12-28 14:09:45 UTC
Created attachment 56467 [details]
PDF containing 2 JPEG attachments

Here is an example PDF with 2 JPEG attachments.
Comment 2 Nickolay V. Shmyrev 2005-12-28 14:12:36 UTC
It would be nice feature
Comment 3 Martin Kretzschmar 2005-12-28 19:13:52 UTC
There's currently work underway to add support for this to the poppler library

http://lists.freedesktop.org/archives/poppler/2005-December/001321.html
Comment 4 Nickolay V. Shmyrev 2006-02-23 19:13:11 UTC
I think we can include attachments tab in properties page. Poppler part is already implemented, so this will be great task for gnome lover
Comment 5 Carlos Garcia Campos 2006-03-05 18:29:00 UTC
I think it could be difficult to find the attachments in the properties dialog. I had in mind something like this:

http://carlosgc.linups.org/files/ev-with-attachs.png
http://carlosgc.linups.org/files/ev-with-attachs-expanded.png
http://carlosgc.linups.org/files/ev-without-attachs.png

At the moment they are only mockups, but if it make sense I'll prepare a patch. 
Comment 6 Carlos Garcia Campos 2006-04-02 18:29:14 UTC
Created attachment 62619 [details] [review]
Proposed patch

Here is the promised patch. You can test it with the following pdf that I found googling for a while:

http://www.shubhayan.org/media/Press.Release-08.08.2005.pdf

There are still things to do, but I think the patch is large enough and I'm not sure about those things:

* Add an 'open with' option to context-menu
* Allow multiple selection of attachments
* Store metadata about attachment bar (expanded/not expanded)
Comment 7 Nickolay V. Shmyrev 2006-04-03 00:32:16 UTC
Well, patch needs additional work, for example we need to

* Update user documentation
* Allow multiple selection
* Store metadata

I am not sure we want to add "Open with", it's too complicated for us. I've committed it, thanks Carlos.
Comment 8 Wouter Bolsterlee (uws) 2006-04-12 13:17:21 UTC
I think the attachment bar should be shown by default or another UI should be implemented, since the current UI makes it very hard to find out whether a file has attachments.
Comment 9 Carlos Garcia Campos 2006-04-12 15:48:15 UTC
The attachment bar is always shown when the document has attachments. It could be expanded or not, but it's always shown. Do you mean that the attachments bar should be expanded by default? I think it could be annoying, because if you just want to read the document you will have to close the bar every time. It takes a lot of space when is not going to be used. 
Comment 10 Nickolay V. Shmyrev 2006-04-12 20:24:59 UTC
Let's just implement metadata storage for this setting
Comment 11 Wouter Bolsterlee (uws) 2006-04-24 15:21:47 UTC
The problem is that the attachment bar looks like a status bar and is not easily discoverable. Why not add a sidebar (index, thumbnails, attachments) and an icon somewhere that indicates that the document has attachments? Such an icon would also be great for secured/encrypted pdf files (showing the lock icon somewhere).
Comment 12 Carlos Garcia Campos 2006-04-24 17:32:27 UTC
hmm, I think that the current attachments bar is easier to discover rather than an icon. 
Anyway, in case of using an icon, where could we put such an icon?
Comment 13 Nickolay V. Shmyrev 2006-04-24 17:47:28 UTC
We can create attachment sidebar btw. And probably we should bring back statusbar,  we need it anyhow.
Comment 14 Carlos Garcia Campos 2006-04-29 18:34:50 UTC
Created attachment 64535 [details] [review]
Allow multiple selection

This patch allows multiple selection of attachments. Ok to commit?
Comment 15 Nickolay V. Shmyrev 2006-05-11 05:00:27 UTC
About the discoverablility - yeah, we need a statusbar. I think we also should update our documentation, but in general this bug is now fixed.
Comment 16 Troy Henderson 2006-05-26 14:18:01 UTC
I tested Evince 0.5.3 on the PDF listed above and it works fine.  However, I have a PDF that contains an attachment that I created, and Evince is not showing an attachment.  If I open the same PDF in Acroread, then it's there.  The PDF is located at

http://www.tlhiv.org/papers/tb84henderson.pdf

Troy
Comment 17 Nickolay V. Shmyrev 2006-05-26 14:38:34 UTC
Troy, please create separate __poppler__ bug about that.
Comment 18 Troy Henderson 2006-05-26 16:48:51 UTC
Done.  Here's the Poppler bug:

https://bugs.freedesktop.org/show_bug.cgi?id=7044