GNOME Bugzilla – Bug 324857
MinGW build fixes
Last modified: 2016-04-30 19:07:58 UTC
Steps to reproduce: 1. Try to compile libxslt (fails because attrvt.o isn't specified in Makefile.mingw and it references libxml2 using "-llibxml2" which should be "-lxml2.dll" or "-lxml2") 2. xsltproc enters endless recursion and produces stack overflow as soon as the application tries to use *snprintf Stack trace: None available because it takes a loooong time to produce the crash due to stack overflow Other information: I'll apply a patch that fixes the problem.
Created attachment 56320 [details] [review] Patch that fixes the MinGW build and the resulting libs/executable I also replaced all "-llibxml2" with "-lxml2.dll" to always use the dynamic libxml2. I don't know if this makes sense but it seems more natural for the Win32 environment. Another thing that I had to modify was the order of the $(LD) call arguments because otherwise $(LD) was unable to find the libraries for the link process. So I replaced $(LD) $(APP_LDFLAGS) -o $@ $(APPLIBS) $(subst .c,.o,$(UTILS_INTDIR)/$(<F)) with $(LD) $(APP_LDFLAGS) -o $@ $(subst .c,.o,$(UTILS_INTDIR)/$(<F)) $(APPLIBS)
Fixed with the following commit: https://git.gnome.org/browse/libxslt/commit/?id=52e26315b5336f39a6c346a1d0e1595f84253b13 I didn't include the snprintf and -lxml2.dll changes. They weren't necessary for me.