After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 324504 - Add priority to ical output
Add priority to ical output
Status: RESOLVED FIXED
Product: bugzilla.gnome.org
Classification: Infrastructure
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Bugzilla Maintainers
Bugzilla Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-12-19 15:45 UTC by William Jon McCann
Modified: 2005-12-20 01:21 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description William Jon McCann 2005-12-19 15:45:34 UTC
First off, freakin' awesome work with the new bugzilla installation!

One version of the original ical patch added priorities to the output.  However, we had to remove this since priorities are essentially defined by each bugzilla site and not by upstream.

https://bugzilla.mozilla.org/show_bug.cgi?id=235459

It would be nice for us (bugzilla.gnome.org) to add priorities that are relevant for GNOME.

This would make the order that appears in the clock applet make more sense.
Comment 1 Olav Vitters 2005-12-19 17:29:08 UTC
Ah, you wrote the patch. Good :)

Exactly what parts need to be added? I looked at this patch:
https://bugzilla.mozilla.org/attachment.cgi?id=142158&action=view

Is it just this for the list.ics.tmpl:
> +[% FOREACH priority = priorities %]
> +[% NEXT IF !priority %]
> +[% IF bug.priority == priority %]
> +PRIORITY:[% loop.count() FILTER html %]
> +[% END %]
> +[% END %]

(the buglist.cgi I understand)
Comment 2 William Jon McCann 2005-12-19 17:52:20 UTC
My memory is a little rusty let me try to reconstruct what I was thinking. :)

The spec for iCalendar is:
http://www.ietf.org/rfc/rfc2445.txt

See Section 4.8.1.9 for the definition of the PRIORITY field.

Based on that, how about the following mapping from our priorities as shown in the web interface to PRIORITY values:

"Immediate" => 1
"Urgent"    => 2
"High"      => 3
"Normal"    => 5
"Low"       => 6

The patch that you quote does a very crude mapping, I think we can do better.

Should patches be against http://cvs.gnome.org/viewcvs/bugzilla-new/ ?
Comment 3 Olav Vitters 2005-12-19 18:02:22 UTC
No bugzilla-newer :)

I'm thinking of putting a hash in template/en/default/global/field-descs.none.tmpl or just the list.ics.tmpl and using that. The PRIORITY: should only be added if the bugs priority is in the hash (to be sure, although I do not believe we will ever change our priorities). 
Comment 4 William Jon McCann 2005-12-19 18:30:51 UTC
Sounds good to me.  You're way more familiar with the code then I am anymore. :)
Comment 5 Olav Vitters 2005-12-19 22:13:49 UTC
$ cicl
Checking in ChangeLog;
/cvs/gnome/bugzilla-newer/ChangeLog,v  <--  ChangeLog
new revision: 1.293; previous revision: 1.292
done
Checking in template/en/default/list/list.ics.tmpl;
/cvs/gnome/bugzilla-newer/template/en/default/list/list.ics.tmpl,v  <--  list.ics.tmpl
new revision: 1.2; previous revision: 1.1
done
Comment 6 William Jon McCann 2005-12-20 01:21:51 UTC
It works.  Thanks Olav!