Created attachment 56098 [details] [review]
Proposed patch

Created attachment 56099 [details]
Screenshot

thanks, I've included this into HEAD now.

2005-12-17  Emmanuele Bassi  <ebassi@cvs.gnome.org>

	A bunch UI fixes from Dennis Cranston, and a bunch of fixes triggered
	by a down of dict.org.

	* libgdict/gdict-defbox.c, src/gdict-window.c: fix lifetime of the
	GdictContext and related signal handlers.

	* libgdict/gdict-client-context.c (gdict_client_context_finalize),
	(clear_command_queue): fix a double free bug issued when finalizing a
	ClientContext with a non-empty queue (patch by Paolo Borelli).

	* libgdict/gdict-client-context.c: emit "error" when unable to connect
	to the dictionary server.

	* libgdict/gdict-defbox.c:  UI fixes for the find widgets (patch by
	Dennis Cranston).

	* src/gdict-window.c:  UI fixes.  Fix widget spacing.  Change 
	"find" back to "look up" to avoid confusion caused by its 
	double use (patch by Dennis Cranston).

	* libgdict/gdict-source.c: fix the "context" propery;

	* src/gdict-window.c: add "source-name" and "word" constructor
	properties, so that a window might be created with a pre-defined
	source and word to look up.

	* libgdict/gdict-app.c (gdict_create_window),
	(gdict_window_created_cb), (gdict_window_destroy_cb): fix multiple
	registration of callbacks and remove the loop on the windows list for
	good (based on a patch by Paolo Borelli).

	* src/gdict-app.c: begin command line arguments support, and attach
	a GOptionContext to gnome_program_init().

Created attachment 56136 [details] [review]
Proposed patch

It looks like some of my previously attached patch was not applied to CVS.  This patch includes the missing parts.  Thanks.

I am reopening because some of the previously attached patch did not get applied to cvs.

thanks.

as for the second chunk of the patch, the packing layout seems like:

  find_pane (HBox)
    Label
    HBox
      find_entry (Entry)
      Separator
      find_prev (Button)
      HBox
        find_next (Button)
        find_label (Label)

which doesn't seem "logical".  the logical layout would be:

  find_pane
    HBox
      Label
      find_entry
    Separator
    HBox
      find_prev
      find_next
    find_label

better:

  find_pane (HBox, homogeneous=false, spacing=6)
    HBox (homogeneous=false, spacing=6)
      Label
      find_entry
    Separator
    HBox (homogeneous=false, spacing=6)
      find_prev
      find_next
      find_label

this yields a UI like your screenshot, while retaining a logical separation for the widgets inside the layout.

Regarding comment #7, the distance between the label and entry should be 12 not 6 pixels.  While, the distance between the buttons should be 6 pixels.  

Regarding comment #6, the reason for the hbox2 with 0 pixel spacing is to allow the next button to align with the other widgets on the right edge of the main window.  So, if the "Not found" label is hidden we don't have 6 pixels of empty space on the right side.

My proposed layout whould be like this.

  find_pane (HBox, homogeneous=false, spacing=0)
    HBox (homogeneous=false, spacing=6)
      HBox (homogeneous=false, spacing=12)
        Label
        find_entry
      Separator
      find_prev
      find_next
    find_label

okay, I'm going to update the layout as shown in comment #9

fixed in HEAD

Your changes look great.