After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 323904 - GtkEditable header is slightly incorrect
GtkEditable header is slightly incorrect
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.90.x
Other All
: Normal minor
: 3.0
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2005-12-12 17:25 UTC by Johan (not receiving bugmail) Dahlin
Modified: 2010-09-17 18:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (1.57 KB, patch)
2005-12-12 17:27 UTC, Johan (not receiving bugmail) Dahlin 		none Details | Review
Use GtkEditableInterface instead GtkEditableClass (10.05 KB, patch)
2010-09-11 02:18 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Johan (not receiving bugmail) Dahlin 2005-12-12 17:25:34 UTC 
Since GtkEditable is an interface it should have a typedef called
GtkEditableIface and not GtkEditableClass. It's also missing a macro to fetch
interface which follows the standard conventions: *_GET_IFACE instead of
*_GET_CLASS.
Comment 1 Johan (not receiving bugmail) Dahlin 2005-12-12 17:27:14 UTC 
Created attachment 55902 [details] [review]
proposed patch

Rename struct, add new macro.
Backwards compatibility is preserved using a typedef. 
No deprecation is enforced, perhaps the old struct/macros should be protected
by a n ifdef.
Comment 2 Matthias Clasen 2005-12-12 18:09:26 UTC 
Is this misnomer causing problems for you ?
Comment 3 Johan (not receiving bugmail) Dahlin 2007-01-16 14:08:14 UTC 
(In reply to comment #2)
> Is this misnomer causing problems for you ?
> 

Yes, the header scanner and code generator in pygtk assumes that the name of an interface ends with IfAce.
Comment 4 Matthias Clasen 2007-01-16 15:44:45 UTC 
I'd say the header scanner in pygtk is a bit too picky then. 
Is this the only place where it falls over ?
Comment 5 Christian Dywan 2010-09-10 16:17:56 UTC 
This could be renamed in GTK+ 3, if it really helps.
Comment 6 Javier Jardón (IRC: jjardon) 2010-09-11 02:18:00 UTC 
Created attachment 170003 [details] [review]
Use GtkEditableInterface instead GtkEditableClass

Updated patch against current master

I've used *Interface because is the name used in the G_DEFINE_INTERFACE() macro
Comment 7 Matthias Clasen 2010-09-17 15:16:30 UTC 
Review of attachment 170003 [details] [review]:

lets do this for 3.0
Comment 8 Javier Jardón (IRC: jjardon) 2010-09-17 18:25:28 UTC 
Comment on attachment 170003 [details] [review]
Use GtkEditableInterface instead GtkEditableClass

commit efbf04236e04c3c9e5ce7466738d6c33e552eb0f
Comment 9 Javier Jardón (IRC: jjardon) 2010-09-17 18:25:42 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.