After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 323509 - gconf_value_decode() broken for schemas
gconf_value_decode() broken for schemas
Status: RESOLVED FIXED
Product: GConf
Classification: Deprecated
Component: gconf
CVS HEAD
Other Linux
: Normal normal
: ---
Assigned To: GConf Maintainers
GConf Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-12-07 23:24 UTC by Nicolas Peninguy
Modified: 2006-01-03 16:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (856 bytes, patch)
2005-12-07 23:26 UTC, Nicolas Peninguy 		accepted-commit_now Details | Review

Description Nicolas Peninguy 2005-12-07 23:24:07 UTC 
gconf_value_decode() doesn't work for schemas.
Comment 1 Nicolas Peninguy 2005-12-07 23:26:54 UTC 
Created attachment 55766 [details] [review]
Proposed patch

Patch.
Comment 2 Mark McLoughlin 2005-12-08 07:53:14 UTC 
Patch looks good to me, can you commit it to HEAD with a ChangeLog entry ?
Comment 3 Nicolas Peninguy 2005-12-08 16:36:24 UTC 
I do not have CVS write access, can someone please commit it ?
Comment 4 Kjartan Maraas 2005-12-08 20:08:22 UTC 
Commited on HEAD. Should this go into the stable branch as well?
Comment 5 Nicolas Peninguy 2005-12-09 09:03:32 UTC 
Don't know, but if you backport this into stable branch it's probably a good
idea to also backport the fix for gconf_value_encode in
http://cvs.gnome.org/viewcvs/gconf/gconf/gconf-internals.c?r1=1.132&r2=1.133
because this function used to always return NULL for schemas !
Comment 6 Nicolas Peninguy 2005-12-22 22:18:11 UTC 
Oops, this line

+        if (*end != ',')

should have been


+        if (*s != ',')

Since end is always null at this point! Sorry :-(
Comment 7 Nicolas Peninguy 2005-12-24 16:43:31 UTC 
As said in comment #6, the patch was wrong and makes this function crash for schema...
Comment 8 Mark McLoughlin 2006-01-03 16:36:46 UTC 
Thanks

2006-01-03  Mark McLoughlin  <mark@skynet.ie>

        Pointed out by Nicolas Peninguy <npeniguy@gmail.com>
        in bug #323509

        * gconf/gconf-internals.c: (gconf_value_decode): fix crasher
        with previous fix for decoding schemas