After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 323361 - cairosimple example breaks jhbuild
cairosimple example breaks jhbuild
Status: RESOLVED DUPLICATE of bug 319632
Product: pango
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: pango-maint
pango-maint
Depends on:
Blocks:
 
 
Reported: 2005-12-06 10:54 UTC by Martyn Russell
Modified: 2005-12-31 14:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to check for PNG functions before calling them. (746 bytes, patch)
2005-12-06 10:56 UTC, Martyn Russell 		none Details | Review
Patch to only build cairosimple if Cairo is built with PNG functions (1.82 KB, patch)
2005-12-31 12:48 UTC, Martyn Russell 		none Details | Review

Description Martyn Russell 2005-12-06 10:54:30 UTC 
When building Cairo from jhbuild, it fails on cairosimple.c because
cairo_surface_write_to_png() is not defined.  The example needs a check for
CAIRO_HAS_PNG_FUNCTIONS before calling the function.
Comment 1 Martyn Russell 2005-12-06 10:56:11 UTC 
Created attachment 55678 [details] [review]
Patch to check for PNG functions before calling them.
Comment 2 Behdad Esfahbod 2005-12-06 15:49:39 UTC 
While the patch fixes your problem, it probably opens this other bug that
"cairosimple doesn't produce anything"...  In the past Owen has said that it's
your resposibility to make sure your cairo has PNG functions.  And you really
better have them.  Anyway, I may go one and apply a modified version of your
patch...
Comment 3 Behdad Esfahbod 2005-12-26 07:54:51 UTC 
Can you attach a patch that doesn't build cairosimple if png functions are not available?
Comment 4 Martyn Russell 2005-12-31 12:48:39 UTC 
Created attachment 56588 [details] [review]
Patch to only build cairosimple if Cairo is built with PNG functions
Comment 5 Owen Taylor 2005-12-31 14:34:02 UTC 
I dislike this. Propagating checks for a weirdly built cairo all over
the stack doesn't benefit anyone.

https://bugs.freedesktop.org/show_bug.cgi?id=5062

The only patch that might make sense would be a patch to add
an AC_MSG_ERROR() in that case until Cairo is fixed to not sllently
misbuild.


*** This bug has been marked as a duplicate of 319632 ***